ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-6016) Get rid of checking topology hash in ackTopology
Date Wed, 09 Aug 2017 16:12:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-6016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120159#comment-16120159
] 

ASF GitHub Bot commented on IGNITE-6016:
----------------------------------------

GitHub user glukos opened a pull request:

    https://github.com/apache/ignite/pull/2424

    IGNITE-6016 Get rid of checking topology hash in ackTopology

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-6016

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/2424.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2424
    
----
commit 2d409a7f9a52c6769e2f0b7858e49691d04313d6
Author: Ivan Rakov <ivan.glukos@gmail.com>
Date:   2017-08-09T16:09:06Z

    IGNITE-6016 Get rid of checking topology hash in ackTopology

----


> Get rid of checking topology hash in ackTopology
> ------------------------------------------------
>
>                 Key: IGNITE-6016
>                 URL: https://issues.apache.org/jira/browse/IGNITE-6016
>             Project: Ignite
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 2.1
>            Reporter: Ivan Rakov
>            Assignee: Ivan Rakov
>             Fix For: 2.2
>
>
> We check topologyHash in ackTopology in order to avoid printing "Topology snapshot" message
twice. It's redundant - we can just atomically increase topology version with GridAtomicLong#setIfGreater.
> It's the only usage of topology hash in Ignite, so we should remove it with all related
tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message