ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nikolay Tikhonov (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IGNITE-5355) Create task with release tools
Date Fri, 18 Aug 2017 09:32:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-5355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131970#comment-16131970
] 

Nikolay Tikhonov edited comment on IGNITE-5355 at 8/18/17 9:31 AM:
-------------------------------------------------------------------

[~lexa],
Thank you for your contribution! I've reviewed changes and have some minor comments:
* Can you to make sure that org.json.json:20170516 dependency compatible with apache license?
* Some minor code style issues (space, name convention and etc);
* Use StringBuilder instead of simple string concatenation in loop;
* Is it possible to add test on this tool?


was (Author: ntikhonov):
[~lexa],
Thank you for your contribution! I've reviewed changes and have some minor comments:
* Can you to make sure that org.json.json:20170516 dependency compatible with apache license?
* Some minor code style issues (space, name convention and etc);
* Use StringBuilder instead of simple string concatenation in loop.

> Create task with release tools
> ------------------------------
>
>                 Key: IGNITE-5355
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5355
>             Project: Ignite
>          Issue Type: Task
>          Components: documentation
>            Reporter: Aleksey Chetaev
>            Assignee: Aleksey Chetaev
>
> 1. Create task for auto-generate HTML formatted releases notes



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message