Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
Date: Wed, 12 Jul 2017 16:01:00 +0000 (UTC)
From: "Evgenii Zhuravlev (JIRA)" <jira@apache.org>
To: issues@ignite.apache.org
Message-ID: <JIRA.13082835.1498573306000.229777.1499875260116@Atlassian.JIRA>
In-Reply-To: <JIRA.13082835.1498573306000@Atlassian.JIRA>
References: <JIRA.13082835.1498573306000@Atlassian.JIRA> <JIRA.13082835.1498573306506@jira-lw-us.apache.org>
Subject: [jira] [Commented] (IGNITE-5597) Wrong javadoc in Affinity and
 AffinityFunction for REPLICATED cache
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 12 Jul 2017 16:01:26 -0000


    [ https://issues.apache.org/jira/browse/IGNITE-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084222#comment-16084222 ] 

Evgenii Zhuravlev commented on IGNITE-5597:
-------------------------------------------

>For fully replicated caches this method the same way as a partitioned cache.
I think you've forgot verb here.

> Wrong javadoc in Affinity and AffinityFunction for REPLICATED cache
> -------------------------------------------------------------------
>
>                 Key: IGNITE-5597
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5597
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 1.7
>            Reporter: Evgenii Zhuravlev
>            Assignee: Andrei Yakushin
>              Labels: javadoc
>             Fix For: 2.2
>
>
> RendezvousAffinityFunction.getPartitions() Javadoc says:
> {code:java}
>      * Note that for fully replicated caches this method should always
>      * return {@code 1}.
> {code}
> but it's not true, it works the same as PARTITIONED cache.
> Affinity.mapKeyToNode(K key) javadoc says:
> {code:java}
>      * <li>
>      *      For fully replicated caches first node ID returned by {@link AffinityFunction}
>      *      is returned.
>      * </li>
>      * <li>For partitioned caches, primary node for the given key is returned.</li>
> {code}
> it looks confusing, while REPLICATED cache has primary nodes for keys as PRATITIONED.
> Also,  
> {code:java}
> * Provides affinity information to detect which node is primary and which nodes are
>  * backups for a partitioned cache.
> {code}
> Affinity matter for REPLICATED cache too.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)