ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-5572) DDL: Support ALTER TABLE ADD COLUMN
Date Tue, 25 Jul 2017 23:00:07 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-5572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100917#comment-16100917
] 

ASF GitHub Bot commented on IGNITE-5572:
----------------------------------------

GitHub user alexpaschenko opened a pull request:

    https://github.com/apache/ignite/pull/2344

    IGNITE-5572

    ALTER TABLE ADD COLUMN

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-5572

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/2344.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2344
    
----
commit 5ccc0e250e91f662fe012bd2c000d67974582b19
Author: Alexander Paschenko <alexander.a.paschenko@gmail.com>
Date:   2017-07-19T19:00:47Z

    IGNITE-5572 ALTER TABLE ADD COLUMN parsing

commit 1602c29f1e4c73f6b926da12f1ad944564529acc
Author: Alexander Paschenko <alexander.a.paschenko@gmail.com>
Date:   2017-07-25T15:37:48Z

    IGNITE-5572 ALTER TABLE ADD COLUMN (no tests)

commit 4a6b39c1f93676f45a3ab0da9b39ec691357a547
Author: Alexander Paschenko <alexander.a.paschenko@gmail.com>
Date:   2017-07-25T20:51:43Z

    IGNITE-5572 First ALTER TABLE ADD COLUMN tests

commit e15e7da7914dd6f73e7bd995bbf4ff166c1e24c3
Author: Alexander Paschenko <alexander.a.paschenko@gmail.com>
Date:   2017-07-25T22:49:27Z

    IGNITE-5572 Minors

commit 4f26e00dc48af1d50c08adb683d6006b590cea9e
Author: Alexander Paschenko <alexander.a.paschenko@gmail.com>
Date:   2017-07-25T22:57:35Z

    Merge remote-tracking branch 'apache/master' into ignite-5572

----


> DDL: Support ALTER TABLE ADD COLUMN
> -----------------------------------
>
>                 Key: IGNITE-5572
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5572
>             Project: Ignite
>          Issue Type: Task
>          Components: sql
>            Reporter: Vladimir Ozerov
>            Assignee: Alexander Paschenko
>             Fix For: 2.2
>
>
> We should start gradual implementation of {{ALTER TABLE}} command. Let's start with the
most simple part - {{ADD COLUMN}}. Proposed design:
> 1) Send a message over a ring, similar to how we do that for create index
> 2) On local node: update relevant QueryEntity, update data strcutrues in {{GridQueryProcessor}},
update {{IgniteH2Indexing}} data structures, execute {{ALTER TABLE}} command on H2 database
(global table lock must be acquired).
> 3) Make sure that update to {{QueryEntity}} is properly saved if persistence is enabled.
> Feature should be covered with tests thoroughly:
> 1) Positive cases
> 2) Negative cases (no schema, no table, column already exists)
> 3) Test with concurrent SQL operations
> 4) Test with concurrent node restarts



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message