ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Chugunov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-5562) Assertions in TCP discovery SPI when NTP is moving time backwards
Date Tue, 20 Jun 2017 14:38:00 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-5562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055862#comment-16055862
] 

Sergey Chugunov commented on IGNITE-5562:
-----------------------------------------

Thinking more generally I believe we must prohibit any assertions in metrics. We may print
out warnings to logs at max.

> Assertions in TCP discovery SPI when NTP is moving time backwards
> -----------------------------------------------------------------
>
>                 Key: IGNITE-5562
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5562
>             Project: Ignite
>          Issue Type: Bug
>          Components: general
>    Affects Versions: 1.7
>            Reporter: Alexey Goncharuk
>             Fix For: 2.1
>
>
> In several places in TcpDiscoverySPI, when metrics are updated, we assert that time is
not negative. However, in some cases, this invariant may fail because of time adjustments.

> Since a missed metric is not critical for us, we should remove these assertions and replace
negative time with 0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message