ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-5380) Validate cache QueryEntities in discovery thread
Date Mon, 05 Jun 2017 16:12:04 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-5380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037149#comment-16037149
] 

ASF GitHub Bot commented on IGNITE-5380:
----------------------------------------

GitHub user alexpaschenko opened a pull request:

    https://github.com/apache/ignite/pull/2082

    IGNITE-5380

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-5380

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/2082.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2082
    
----
commit 79917bfbc67eefa68d799746158c0d5ab5fcc19f
Author: Alexander Paschenko <alexander.a.paschenko@gmail.com>
Date:   2017-06-01T15:33:35Z

    IGNITE-5380 Query entity conflicts validation - first steps

commit 11736f3623fee692b97246b05854233ea06431c2
Author: Alexander Paschenko <alexander.a.paschenko@gmail.com>
Date:   2017-06-02T10:02:32Z

    Merge remote-tracking branch 'apache/master' into ignite-5380

commit 0bcf86240db99c697f2ae73ae1a472f867862547
Author: Alexander Paschenko <alexander.a.paschenko@gmail.com>
Date:   2017-06-02T13:02:42Z

    Merge remote-tracking branch 'apache/master' into ignite-5380
    
    # Conflicts:
    #	modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/ddl/DdlStatementsProcessor.java

commit 621879d687480428bc375dd7c150712cf400b786
Author: Alexander Paschenko <alexander.a.paschenko@gmail.com>
Date:   2017-06-02T13:29:41Z

    IGNITE-5380 Additional schema wide index name uniqueness check.

commit ac06866faebb5d1f1f8d74ad0e99026e9a5f2264
Author: Alexander Paschenko <alexander.a.paschenko@gmail.com>
Date:   2017-06-02T13:35:49Z

    Merge remote-tracking branch 'apache/master' into ignite-5380

commit bce568648a6bc2f97bff0e7b36ced8fa08c26aee
Author: Alexander Paschenko <alexander.a.paschenko@gmail.com>
Date:   2017-06-05T11:45:13Z

    Merge remote-tracking branch 'apache/master' into ignite-5380

commit 0ebf6c7cf3e453e15cc8b84ac0dda48e1bf4037e
Author: Alexander Paschenko <alexander.a.paschenko@gmail.com>
Date:   2017-06-05T15:35:10Z

    IGNITE-5380 Tests.

commit 43a50f94dfc2aaf08b209d8d080ead885b5c02a9
Author: Alexander Paschenko <alexander.a.paschenko@gmail.com>
Date:   2017-06-05T15:35:44Z

    Merge remote-tracking branch 'apache/master' into ignite-5380

commit 0c83f340a1351c56d6bedb477cf1e61b05184909
Author: devozerov <vozerov@gridgain.com>
Date:   2017-06-05T15:45:59Z

    Review.

commit a8c2ecdd8c340d7b17d193800fbd88c7342828e4
Author: devozerov <vozerov@gridgain.com>
Date:   2017-06-05T15:52:49Z

    Review (unwrap issue).

commit 910b6595ce0b6ff8e8a7639e1a8195989d8f22ab
Author: Alexander Paschenko <alexander.a.paschenko@gmail.com>
Date:   2017-06-05T16:00:39Z

    IGNITE-5380 Minor.

commit 8dd7930726deb7f1bcb900e5276ec36b08ea631e
Author: Alexander Paschenko <alexander.a.paschenko@gmail.com>
Date:   2017-06-05T16:08:55Z

    IGNITE-5380 Minor.

commit e0fbf03b552905f1c251baea38fd2934999e7f69
Author: Alexander Paschenko <alexander.a.paschenko@gmail.com>
Date:   2017-06-05T16:09:26Z

    Merge remote-tracking branch 'apache/master' into ignite-5380

----


> Validate cache QueryEntities in discovery thread
> ------------------------------------------------
>
>                 Key: IGNITE-5380
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5380
>             Project: Ignite
>          Issue Type: Task
>          Components: cache, sql
>            Reporter: Vladimir Ozerov
>            Assignee: Alexander Paschenko
>             Fix For: 2.1
>
>
> Consider the following case:
> 1) Execute SQL: TABLE Person ...}}
> 2) Then again: TABLE Person ...}}
> Second call will lead to exception in exchange thread and will hang the whole cluster.

> We need to add validation of {{CacheConfiguration.queryEntities}} wrt to other caches.
This check should be performed in discovery thread. Note that we cannot rely on {{GridQueryProcessor}}
or {{IgniteH2Indexing}} state, as some cache start requests may already be enqueued to exchange
worker. Instead, we should perform cross-cache validation base only on two things:
> 1) {{DynamicCacheDescriptor.cacheCfg}}
> 2) {{DynamicCacheDescriptor.schema}}
> That is, we should resolve cache schema name from configuration, tables and indexes from
schema, and then cross-validate them with other caches.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message