ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vyacheslav Daradur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-5097) BinaryMarshaller should write ints in "varint" encoding where it makes sense
Date Thu, 01 Jun 2017 19:16:04 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-5097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033515#comment-16033515
] 

Vyacheslav Daradur commented on IGNITE-5097:
--------------------------------------------

[~vozerov], thanks for your notes.
bq. doWriteUnsignedVarint should have safe and unsafe implementations
Great idea!
bq. looks like DECIMAL is read incorrectly here
Fixed.
bq. Looks like varint applied to all arrays except of ENUM_ARR. Why?
Hmm, it has been applied already. I mean BinaryWriterExImpl#doWriteEnumArray and BinaryUtils#doReadBinaryEnumArray.

I've fixed that.
Sent to [ci.test|http://ci.ignite.apache.org/viewQueued.html?itemId=643274]

> BinaryMarshaller should write ints in "varint" encoding where it makes sense
> ----------------------------------------------------------------------------
>
>                 Key: IGNITE-5097
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5097
>             Project: Ignite
>          Issue Type: Task
>          Components: general
>    Affects Versions: 2.0
>            Reporter: Vladimir Ozerov
>            Assignee: Vyacheslav Daradur
>              Labels: important, performance
>             Fix For: 2.1
>
>
> There are a lot of places in the code where we write integers for some special purposes.
Quite often their value will be vary small, so that applying "varint" format could save a
lot of space at the cost of very low additional CPU overhead. 
> Specifically:
> 1) Array/collection/map lengths
> 2) BigDecimal's (usually will save ~6 bytes)
> 3) Strings
> 4) Enum ordinals



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message