Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 968E6200C81 for ; Fri, 26 May 2017 14:11:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 952C0160BC8; Fri, 26 May 2017 12:11:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D8E6C160BB8 for ; Fri, 26 May 2017 14:11:09 +0200 (CEST) Received: (qmail 92681 invoked by uid 500); 26 May 2017 12:11:09 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 92672 invoked by uid 99); 26 May 2017 12:11:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 May 2017 12:11:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 94AA91AF9D3 for ; Fri, 26 May 2017 12:11:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id KFSw7enjgzLm for ; Fri, 26 May 2017 12:11:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 62C4B60E12 for ; Fri, 26 May 2017 12:11:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 83DC5E0A64 for ; Fri, 26 May 2017 12:11:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8496221B57 for ; Fri, 26 May 2017 12:11:04 +0000 (UTC) Date: Fri, 26 May 2017 12:11:04 +0000 (UTC) From: "Dmitry Karachentsev (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-4477) Fix IgniteFuture.listen() and IgniteFuture.chain() semantics MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 26 May 2017 12:11:10 -0000 [ https://issues.apache.org/jira/browse/IGNITE-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026197#comment-16026197 ] Dmitry Karachentsev commented on IGNITE-4477: --------------------------------------------- [~vozerov], Fixed, please check. > Fix IgniteFuture.listen() and IgniteFuture.chain() semantics > ------------------------------------------------------------ > > Key: IGNITE-4477 > URL: https://issues.apache.org/jira/browse/IGNITE-4477 > Project: Ignite > Issue Type: Task > Components: general > Affects Versions: 1.8 > Reporter: Vladimir Ozerov > Assignee: Dmitry Karachentsev > Labels: important > Fix For: 2.1 > > > *Problem* > We allow users to pass continuations to {{IgniteFuture}} which will be executed on future completion. This can be done through {{listen}} or {{chain}} methods. > However, continuation semantics is broken intrinsically: > 1) If future is already completed, user code executed in the same thread; > 2) If future is not completed yet, it will be executed in completion thread. > Neither of this options are valid because it easily leads to starvation. E.g.: > {code} > IgniteFuture fut = cache.getAsync(key2); > fut.listen(fut0 -> { > cache.put(key2, val2); // Possible deadlock, because invoked in sys pool; > }); > {code} > *Solution* > 1) By default callbacks must be executed asynchronously in some common pool (public pool? new "callback pool"? FJP?) > 2) It should be possible to specify where to execute a callback explicitly: > {code} > IgniteFuture.listen(IgniteClosure, ExecutorService); > {code} > 3) We may want to expose our public pool on API for convenience. -- This message was sent by Atlassian JIRA (v6.3.15#6346)