ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-5287) SQL: CacheConfiguration.sqlEscapeAll must affect only predefined objects
Date Thu, 25 May 2017 10:13:04 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-5287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024483#comment-16024483

ASF GitHub Bot commented on IGNITE-5287:

GitHub user devozerov opened a pull request:




You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-5287

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2004
commit 7dd23aa3f891659c5d455316b9bedda4c26d22b3
Author: devozerov <vozerov@gridgain.com>
Date:   2017-05-24T12:52:15Z


commit 7a7646d46080ec7e22476e744cd4b9973be066b6
Author: devozerov <vozerov@gridgain.com>
Date:   2017-05-24T15:26:11Z

    Implemented normalization logic.

commit 3caf64a42bacf8cbe82d63797473949a521babbb
Author: devozerov <vozerov@gridgain.com>
Date:   2017-05-24T15:36:01Z

    Minor fix. Normalization appears to be fine at this point.

commit c3773cc7de08ff31f70d9c77af55c9b53a55ce06
Author: devozerov <vozerov@gridgain.com>
Date:   2017-05-24T16:31:06Z


commit 37a7c223f604680904d63743de7472ef86a85e6b
Author: devozerov <vozerov@gridgain.com>
Date:   2017-05-24T16:50:45Z


commit cbcc8d4f58fdb0ec9d6b2c5a85b2c6330742be2f
Author: devozerov <vozerov@gridgain.com>
Date:   2017-05-25T07:38:17Z


commit b48c8ff383bd9e174a31f04038f36f13ad0da0a3
Author: devozerov <vozerov@gridgain.com>
Date:   2017-05-25T07:50:24Z

    List of failing tests.

commit f066b7748c3d749cebd2b1bd836f390328ab2462
Author: devozerov <vozerov@gridgain.com>
Date:   2017-05-25T07:55:14Z

    Fixing tests.

commit 23f4f46b05929285ead36164d8a90f685c6dca93
Author: devozerov <vozerov@gridgain.com>
Date:   2017-05-25T08:06:24Z

    WIP on tests.

commit 2195c14f8a203d9709b224ac68962ee8acf57a57
Author: devozerov <vozerov@gridgain.com>
Date:   2017-05-25T08:13:58Z

    WIP on tests.

commit 8e438499f03ad450788a81d1c5d4fcbde9179b6d
Author: devozerov <vozerov@gridgain.com>
Date:   2017-05-25T08:48:37Z

    Table name is always set.

commit 8227e6934f7690bf53bdb6925e03eb4a2f0dfcf3
Author: devozerov <vozerov@gridgain.com>
Date:   2017-05-25T09:19:10Z


commit e790fa76899f974f67708a6f7ff45548260b953d
Author: devozerov <vozerov@gridgain.com>
Date:   2017-05-25T09:23:41Z


commit 266e661f383604ae299125807658fd3f89420d8d
Author: devozerov <vozerov@gridgain.com>
Date:   2017-05-25T09:31:14Z


commit 39d180fc7ec53b49a069b66d65ecc415a49a9ecc
Author: devozerov <vozerov@gridgain.com>
Date:   2017-05-25T10:11:35Z

    Fixing tests.

commit b1aef1585e358a9c05ee4361cc7994d55de93299
Author: devozerov <vozerov@gridgain.com>
Date:   2017-05-25T10:12:23Z

    Enabling tests.


> SQL: CacheConfiguration.sqlEscapeAll must affect only predefined objects
> ------------------------------------------------------------------------
>                 Key: IGNITE-5287
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5287
>             Project: Ignite
>          Issue Type: Bug
>          Components: cache, sql
>            Reporter: Vladimir Ozerov
>            Assignee: Vladimir Ozerov
>             Fix For: 2.1
> Mentioned flag should work as follows:
> 1) If set, all object names (schema, QueryEntity (table, fields and aliases), QueryIndex
(name and fields)) should be left as is.
> 2) Otherwise we should convert them to uppercase, and replace class delimiters (".",
"$") with underscore. 
> This is it. This property should not be used anywhere else. Allmost all usages of {{IgniteH2Indexing.escapeName}}
should go away.

This message was sent by Atlassian JIRA

View raw message