ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Rakov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-5151) Add some warning when offheap eviction occurs
Date Fri, 05 May 2017 16:19:04 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998519#comment-15998519
] 

Ivan Rakov commented on IGNITE-5151:
------------------------------------

Roman, I've looked through your changes and fix looks wrong to me. 
Offheap eviction is page-memory-wide mechanism, unlike cache-wide regular eviction, which
is manageable by EvictionManager of specific cache. Both eviction mechanisms can be active
at the same time, and it's incorrect to show only one warning for both of them.
I think, the best place to show warning for offheap eviction is under _shouldEvict_ flag of
_IgniteCacheDatabaseSharedManager#ensureFreeSpace_ method.

> Add some warning when offheap eviction occurs
> ---------------------------------------------
>
>                 Key: IGNITE-5151
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5151
>             Project: Ignite
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Ksenia Rybakova
>            Assignee: Roman Shtykh
>
> Currently if offheap eviction occurs we are silently losing data. It whould be helpful
to have some warning in log as it's done for onheap eviction.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message