ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vladimir Ozerov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-5052) Implement CREATE/DROP TABLE parsing and execution
Date Mon, 22 May 2017 10:55:04 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-5052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019442#comment-16019442
] 

Vladimir Ozerov commented on IGNITE-5052:
-----------------------------------------

[~al.psc], my comments:
1) {{GridQueryProcessor}} - call to {{GridCacheProcessor.createConfigFromTemplate}} will never
fail even if template doesn't exist; in case of CREATE TABLE we need to throw an exception
2) {{GridQueryProcessor}} - do not use {{IgniteSQLException}} and {{IgniteQueryErrorCode}}
in tihs class; use {{SchemaOperationException}} instead
3) {{GridQueryProcessor.dynamicTableCreate}} - please pass schema name here; it will not be
used for now until schema-related refactoring is ready
4) {{GridSqlQueryParser}} - we need sensible names for "TPL" ({{PARAM_TPL_CACHE}} -> {{PARAM_CACHE_TEMPLATE}},
{{tplCache}} -> {{cacheTemplate}})
5) {{H2DynamicTableSelfTest}} - not included into any test suite
6) {{H2DynamicTableSelfTest}} - invalid JavaDocs on methods

> Implement CREATE/DROP TABLE parsing and execution
> -------------------------------------------------
>
>                 Key: IGNITE-5052
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5052
>             Project: Ignite
>          Issue Type: Task
>          Components: sql
>            Reporter: Vladimir Ozerov
>            Assignee: Alexander Paschenko
>              Labels: important
>             Fix For: 2.1
>
>
> Convert SQL string to relevant Igntie command. This could be:
> - {{createCache}}
> - {{getOrCreateCache}} (for {{IF NOT EXISTS}} case)
> - {{destroyCache}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message