Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6B1DA200C4E for ; Fri, 21 Apr 2017 15:21:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 696E3160BA2; Fri, 21 Apr 2017 13:21:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B0A74160B97 for ; Fri, 21 Apr 2017 15:21:08 +0200 (CEST) Received: (qmail 62204 invoked by uid 500); 21 Apr 2017 13:21:07 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 62195 invoked by uid 99); 21 Apr 2017 13:21:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Apr 2017 13:21:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 865BB1803A3 for ; Fri, 21 Apr 2017 13:21:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 3jWfvi2Ukjb3 for ; Fri, 21 Apr 2017 13:21:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 150CC60D69 for ; Fri, 21 Apr 2017 13:21:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5A592E06C5 for ; Fri, 21 Apr 2017 13:21:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1101F21B53 for ; Fri, 21 Apr 2017 13:21:04 +0000 (UTC) Date: Fri, 21 Apr 2017 13:21:04 +0000 (UTC) From: "Oleg Ignatenko (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-5018) review and improve javadocs in ML module MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 21 Apr 2017 13:21:09 -0000 [ https://issues.apache.org/jira/browse/IGNITE-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978717#comment-15978717 ] Oleg Ignatenko commented on IGNITE-5018: ---------------------------------------- Confirmed reviewer evaluation [in prior comment|https://issues.apache.org/jira/browse/IGNITE-5018?focusedCommentId=15978493&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15978493]. I more closely checked my IDE settings and these turned out broken. After correcting code style settings to idea/ignite_codeStyle.xml I've got report of the errors closely matching one reported by reviewer (mine report was from 34 files instead of 37 but that's probably yet another mistake in my IDE config). Corrections per properly configured code style were pushed to same branch ignite-5018-2, I plan to take yet another look at the code in this branch later to make sure if I haven't missed something else. > review and improve javadocs in ML module > ---------------------------------------- > > Key: IGNITE-5018 > URL: https://issues.apache.org/jira/browse/IGNITE-5018 > Project: Ignite > Issue Type: Task > Components: ml > Reporter: Oleg Ignatenko > Assignee: Oleg Ignatenko > Priority: Minor > Fix For: 2.0 > > > Review and improve javadocs in Ignite ML module (added per IGNITE-4572). To name a few, add descriptions for constructor parameters in classes {{CacheMatrix}}, {{CacheMatrixStorage}}, {{RandomVector}}. Etc. -- This message was sent by Atlassian JIRA (v6.3.15#6346)