ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anton Vinogradov (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IGNITE-4895) TC should fail suite if AssertionError is output to logs
Date Mon, 03 Apr 2017 11:02:41 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-4895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953279#comment-15953279
] 

Anton Vinogradov edited comment on IGNITE-4895 at 4/3/17 11:02 AM:
-------------------------------------------------------------------

That's not true,
we have tests causing "positive" assertions 

For example
1) [INFO ][test-runner-#4966%future.GridEmbeddedFutureSelfTest%][root] Failed with unhandled
error (normal behaviour): java.lang.AssertionError: Test assertion (should be ignored).
2) [INFO ][test-runner-#4883%lang.GridByteArrayListSelfTest%][root] Caught expected error:
java.lang.AssertionError


was (Author: avinogradov):
That's not true,
we have tests causing "positive" assertions 

1) [INFO ][test-runner-#4966%future.GridEmbeddedFutureSelfTest%][root] Failed with unhandled
error (normal behaviour): java.lang.AssertionError: Test assertion (should be ignored).
2) [INFO ][test-runner-#4883%lang.GridByteArrayListSelfTest%][root] Caught expected error:
java.lang.AssertionError

> TC should fail suite if AssertionError is output to logs
> --------------------------------------------------------
>
>                 Key: IGNITE-4895
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4895
>             Project: Ignite
>          Issue Type: Test
>            Reporter: Yakov Zhdanov
>            Assignee: Anton Vinogradov
>            Priority: Blocker
>             Fix For: 2.0
>
>
> AssertionError is never thrown on purpose during the tests opposite to exceptions which
are normal for plenty of scenarios.
> TC should fail if assertion error is output to logs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message