ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrey Gura (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-4795) Inherit TransactionException and update Javadoc
Date Tue, 04 Apr 2017 17:30:42 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955467#comment-15955467
] 

Andrey Gura commented on IGNITE-4795:
-------------------------------------

[~SomeFire],

Yes, I think that {{TransactionCheckedException}} should be removed. From my point of view
it is redundant entity.

About 3 item. I think we should emphasize that all methods that throw {{TransactionException}}
have transactional behaviour in case of cache with atomicity mode {{TRANSACTIONAL}}.

> Inherit TransactionException and update Javadoc
> -----------------------------------------------
>
>                 Key: IGNITE-4795
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4795
>             Project: Ignite
>          Issue Type: Improvement
>          Components: cache, SQL, website
>    Affects Versions: 1.8
>            Reporter: Alexandr Kuramshin
>            Assignee: Ryabov Dmitrii
>              Labels: documentation, important
>             Fix For: 2.0
>
>
> Understanding transactional behaviour is not clear in Javadoc at this point of time.
Even after reading website some doubt remain.
> Proposal.
> 1. Create {{TransactionException}} as the marker of transactional methods and inherit
from it all the existed transactional exceptions like {{TransactionTimeoutException}}, {{TransactionRollbackException}},
{{TransactionHeuristicException}}, {{TransactionOptimisticException}}, etc.
> 2. Update all the transactional methods ({{get}}, {{put}}, {{invoke}}, etc) as throwing
the base {{TransactionException}}. Comment all the {{IgniteCache}} methods whether they are
transactional or not, add {{@see TransactionException}} annotation.
> 3. Make extensive documentation in the header of {{TransactionException}} to get understanding
of transactional and non-transactional methods behaviour.
> 4. Update website and Javadoc to clarify the fact that {{put}} value is cached within
the transaction and affects successive {{get}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message