ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-4354) DML: BinaryObjectBuilder does not sort fields in some cases
Date Sat, 08 Apr 2017 17:13:41 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961896#comment-15961896
] 

ASF GitHub Bot commented on IGNITE-4354:
----------------------------------------

GitHub user alexpaschenko opened a pull request:

    https://github.com/apache/ignite/pull/1759

    IGNITE-4354

    Consistent logic to initialize BinaryObjectBuilderImpl.assignedVals field

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-4354

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/1759.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1759
    
----
commit 48ab0eb3c40f37c3cba421dc43f695884aadf797
Author: Alexander Paschenko <alexander.a.paschenko@gmail.com>
Date:   2017-04-08T17:09:39Z

    IGNITE-4354 Consistent logic to initialize BinaryObjectBuilderImpl.assignedVals field

----


> DML: BinaryObjectBuilder does not sort fields in some cases
> -----------------------------------------------------------
>
>                 Key: IGNITE-4354
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4354
>             Project: Ignite
>          Issue Type: Bug
>          Components: binary, SQL
>    Affects Versions: 1.8
>            Reporter: Pavel Tupitsyn
>            Assignee: Alexander Paschenko
>              Labels: DML
>             Fix For: 2.0
>
>
> One of the setField methods uses TreeMap<> to sort fields, depending on BinaryUtils.FIELDS_SORTED_ORDER.
> However, there are other places where assignedVals is initialized (setField, removeField)
which are not updated to use TreeMap.
> Make sure to put this logic in one place.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message