ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-3581) CPP: Place different enums and constants in separate namespaces or structs.
Date Wed, 12 Apr 2017 16:43:41 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966185#comment-15966185
] 

ASF GitHub Bot commented on IGNITE-3581:
----------------------------------------

GitHub user isapego opened a pull request:

    https://github.com/apache/ignite/pull/1782

    IGNITE-3581: CPP: Moved enums to separate structs

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-3581

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/1782.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1782
    
----
commit 1fd053e9ff683cb8f82d7fc4f5f8ab97c60ec031
Author: Igor Sapego <isapego@gridgain.com>
Date:   2017-04-11T10:42:23Z

    IGNITE-3581: Moved enums to separate structs for Core

commit 54f1cc311524edc099cc8fb0e580c5dfb75a5842
Author: Igor Sapego <isapego@gridgain.com>
Date:   2017-04-12T14:19:01Z

    IGNITE-3581: Implemented for enums from ODBC

commit b4469927c393fe9cc7db8c839e827c7ad29215f5
Author: Igor Sapego <isapego@gridgain.com>
Date:   2017-04-12T15:05:05Z

    IGNITE-3581: Renaming

----


> CPP: Place different enums and constants in separate namespaces or structs.
> ---------------------------------------------------------------------------
>
>                 Key: IGNITE-3581
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3581
>             Project: Ignite
>          Issue Type: Task
>          Components: platforms
>    Affects Versions: 1.6
>            Reporter: Igor Sapego
>            Assignee: Igor Sapego
>              Labels: cpp
>             Fix For: 2.0
>
>
> The common practice is to place enums and constants in separate namespaces or structs.
This way we can group them and avoid name clashes without the need to use long names.
> [Details|http://stackoverflow.com/questions/7090130/enum-in-a-namespace].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message