Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
Date: Tue, 14 Mar 2017 11:29:41 +0000 (UTC)
From: "Andrey Gura (JIRA)" <jira@apache.org>
To: issues@ignite.apache.org
Message-ID: <JIRA.13036679.1484943620000.13095.1489490981686@Atlassian.JIRA>
In-Reply-To: <JIRA.13036679.1484943620000@Atlassian.JIRA>
References: <JIRA.13036679.1484943620000@Atlassian.JIRA> <JIRA.13036679.1484943620261@jira-lw-us.apache.org>
Subject: [jira] [Comment Edited] (IGNITE-4587) Discontinue and remove
 CacheAtomicWriteOrderMode.CLOCK mode
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 14 Mar 2017 11:29:48 -0000


    [ https://issues.apache.org/jira/browse/IGNITE-4587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907918#comment-15907918 ] 

Andrey Gura edited comment on IGNITE-4587 at 3/14/17 11:29 AM:
---------------------------------------------------------------

[~dreamx],

I've review your changes. See my comments below. Please, fix.

# Class {{GridCacheAtomicFullApiSelfTest}}: method {{cacheConfiguration()}} can be removed because it just returns result of base class method.
# Class {{GridCacheAtomicMultiNodeP2PDisabledFullApiSelfTest}}: method {{cacheConfiguration()}} can be removed because it just returns result of base class method.
# Class {{GridCacheReplicatedAtomicMultiNodeFullApiSelfTest}}: method {{cacheConfiguration()}} can be removed because it just returns result of base class method.
# Class {{GridCacheAtomicMessageCountSelfTest}}: methods {{testPartitionedPrimary()}} and {{testClientPrimary()}} should be renamed to {{testPartitioned()}} and {{testClient()}} respectively.
# Class {{GridCacheAtomicNearCacheSelfTest}}: method {{startGridsLocal()}} confuses. Why {{Local}}? May be {{doStartGrids}} or something like.
# Class {{GridCacheAtomicVersionComparator}}: {{ignoreTime}} parameter at {{compare}} method is unused and should be removed.
# Class {{GridCacheInterceptorAbstractSelfTest}}: unused import and methods.
# Class {{GridCacheMapEntry}}, method {{innerUpdate}}, lines 2172 and 2228: {{ignireTime}} variable is always {{true}}. Need remove usage.
# Class {{GridCacheMultithreadedFailoverAbstractTest}}, method {{configuration()}}, line 221: Nested if could be combined with embraced.
# Class {{GridCacheUtils}}: unused imports.
# Class {{GridCacheUtils}}: Bug. Please fix array size and offsets in {{versionToBytes()}} and {{readVersion()}} methods.
# Class {{IgniteUtils}}: Bug. Please fix offsets in {{writeVersion()}} and {{readVersion()}} methods.
# Class {{GridCacheVersion}}: Bug. Integers will be overflowed in {{asGridUuid()}} method. Please replace by {{new UUID(topVer, nodeOrderDrId)}}.
# Class {{GridCacheVersion}}: method {{fieldsCount()}} returns incorrect result. Use {{MessageCodeGenerator}} in order to generate correct code.
# Class {{GridCacheVersionEx}}: incorrect implementations of {{fieldsCount()}}, {{writeTo()}} and {{readFrom()}} methods. Use {{MessageCodeGenerator}} in order to generate correct code.
# Class {{GridCommonAbstractTest}}: unused imports.
# Class {{GridCommonAbstractTest}}: method {{atomicClockModeDelay()}} should be removed.
# Class {{GridDhtAtomicCache}}: I'm not sure about it. It seems that methos {{isFastMap()}} should not be removed. Could you please ask about it on dev list. Check also {{fastMap}} flag in {{GridNearAtomicUpdateFuture}} class.
# Class {{GridDhtAtomicCache}}: Redundant {{catch}} blocks in {{lockEntriesMethod()}}, lines 2899 and 2914.
# Class {{GridNearAtomicSingleUpdateFuture}}: Method {{mapSingleUpdate()}} creates different requests (like {{GridNearAtomicSingleUpdateInvokeRequest}}). For all this requests all instantiations have {{updateVer == null}}. Need to remove this prameter. The same for {{GridNearAtomicUpdateFuture}} class {{mapUpdate()}} and {{mapSingleUpdate()}} methods.
# Class {{IgniteBenchmarkArguments}}: Comand line arguments {{"-wom", "--writeOrderMode"}} were removed. Please, check that there are not this arguments usges in {{modules/yardstick}}.
# Class {{IgniteCacheExpiryPolicyAbstractTest}}: methods {{nearReaderUpdate()}} and {{nearPutAll()}}. It seems that all {{U.sleep()}} calls are redundant now.
# Class {{IgniteCachePutRetryAbstractSelfTest}}: unused import.
# Class {{IgniteConfiguration}}: fields {{clockSyncSamples}} and {{clockSyncFreq}}, corresponding methods and constants {{DFLT_CLOCK_SYNC_SAMPLES}} and {{DFLT_CLOCK_SYNC_FREQUENCY}} should be removed.
# Class {{IgniteSystemProperties}}: 

Also I see a lot of removed tests. I need additional time for analyzing it. Thanks!


was (Author: agura):
[~dreamx],

I've review your changes. See my comments below. Please, fix.

# Class {{GridCacheAtomicFullApiSelfTest}}: method {{cacheConfiguration()}} can be removed because it just returns result of base class method.
# Class {{GridCacheAtomicMultiNodeP2PDisabledFullApiSelfTest}}: method {{cacheConfiguration()}} can be removed because it just returns result of base class method.
# Class {{GridCacheReplicatedAtomicMultiNodeFullApiSelfTest}}: method {{cacheConfiguration()}} can be removed because it just returns result of base class method.
# Class {{GridCacheAtomicMessageCountSelfTest}}: methods {{testPartitionedPrimary()}} and {{testClientPrimary()}} should be renamed to {{testPartitioned()}} and {{testClient()}} respectively.
# Class {{GridCacheAtomicNearCacheSelfTest}}: method {{startGridsLocal()}} confuses. Why {{Local}}? May be {{doStartGrids}} or something like.
# Class {{GridCacheAtomicVersionComparator}}: {{ignoreTime}} parameter at {{compare}} method is unused and should be removed.
# Class {{GridCacheInterceptorAbstractSelfTest}}: unused import and methods.
# Class {{GridCacheMapEntry}}, method {{innerUpdate}}, lines 2172 and 2228: {{ignireTime}} variable is always {{true}}. Need remove usage.
# Class {{GridCacheMultithreadedFailoverAbstractTest}}, method {{configuration()}}, line 221: Nested if could be combined with embraced.
# Class {{GridCacheUtils}}: unused imports.
# Class {{GridCacheUtils}}: Bug. Please fix array size and offsets in {{versionToBytes()}} and {{readVersion()}} methods.
# Class {{IgniteUtils}}: Bug. Please fix offsets in {{writeVersion()}} and {{readVersion()}} methods.
# Class {{GridCacheVersion}}: Bug. Integers will be overflowed in {{asGridUuid()}} method. Please replace by {{new UUID(topVer, nodeOrderDrId)}}.
# Class {{GridCacheVersion}}: method {{fieldsCount()}} returns incorrect result. Use {{MessageCodeGenerator}} in order to generate correct code.
# Class {{GridCacheVersionEx}}: incorrect implementations of {{fieldsCount()}}, {{writeTo()}} and {{readFrom()}} methods. Use {{MessageCodeGenerator}} in order to generate correct code.
# Class {{GridCommonAbstractTest}}: unused imports.
# Class {{GridCommonAbstractTest}}: method {{atomicClockModeDelay()}} should be removed.
# Class {{GridDhtAtomicCache}}: I'm not sure about it. It seems that methos {{isFastMap()}} should not be removed. Could you please ask about it on dev list. Check also {{fastMap}} flag in {{GridNearAtomicUpdateFuture}} class.
# Class {{GridDhtAtomicCache}}: Redundant {{catch}} blocks in {{lockEntriesMethod()}}, lines 2899 and 2914.
# Class {{GridNearAtomicSingleUpdateFuture}}: Method {{mapSingleUpdate()}} creates different requests (like {{GridNearAtomicSingleUpdateInvokeRequest}}). For all this requests all instantiations have {{updateVer == null}}. Need to remove this prameter. The same for {{GridNearAtomicUpdateFuture}} class {{mapUpdate()}} and {{mapSingleUpdate()}} methods.
# Class {{IgniteBenchmarkArguments}}: Comand line arguments {{"-wom", "--writeOrderMode"}} were removed. Please, check that there are not this arguments usges in {{modules/yardstick}}.
# Class {{IgniteCacheExpiryPolicyAbstractTest}}: methods {{nearReaderUpdate()}} and {{nearPutAll()}}. It seems that all {{U.sleep()}} calls are redundant now.
# Class {{IgniteCachePutRetryAbstractSelfTest}}: unused import.

Also I see a lot of removed tests. I need additional time for analyzing it. Thanks!

> Discontinue and remove CacheAtomicWriteOrderMode.CLOCK mode
> -----------------------------------------------------------
>
>                 Key: IGNITE-4587
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4587
>             Project: Ignite
>          Issue Type: Bug
>          Components: cache
>            Reporter: Denis Magda
>            Assignee: Maksim Kozlov
>             Fix For: 2.0
>
>
> {{CacheAtomicWriteOrderMode.CLOCK}} proved to be harmful in production due to timing issues.
> It makes sense to remove it completely in 2.0 release. Migration guide has be updated:
> https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migration+Guide


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)