Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
Date: Thu, 23 Mar 2017 10:39:42 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@ignite.apache.org
Message-ID: <JIRA.13024758.1480596207000.99862.1490265582495@Atlassian.JIRA>
In-Reply-To: <JIRA.13024758.1480596207000@Atlassian.JIRA>
References: <JIRA.13024758.1480596207000@Atlassian.JIRA> <JIRA.13024758.1480596207745@jira-lw-us.apache.org>
Subject: [jira] [Commented] (IGNITE-4351) .NET: Use
 BinaryArrayIdentityResolver by default
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 23 Mar 2017 10:39:47 -0000


    [ https://issues.apache.org/jira/browse/IGNITE-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15938078#comment-15938078 ] 

ASF GitHub Bot commented on IGNITE-4351:
----------------------------------------

GitHub user ptupitsyn opened a pull request:

    https://github.com/apache/ignite/pull/1668

    IGNITE-4351 .NET: Use BinaryArrayIdentityResolver by default

    
You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-4351

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/1668.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1668
    
----
commit b52c0fef588f50221836da279ed564d0815ba4e4
Author: Pavel Tupitsyn <ptupitsyn@apache.org>
Date:   2017-03-23T10:37:59Z

    IGNITE-4351 .NET: Use BinaryArrayIdentityResolver by default

----


> .NET: Use BinaryArrayIdentityResolver by default
> ------------------------------------------------
>
>                 Key: IGNITE-4351
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4351
>             Project: Ignite
>          Issue Type: Improvement
>          Components: platforms
>            Reporter: Pavel Tupitsyn
>            Assignee: Pavel Tupitsyn
>            Priority: Critical
>              Labels: .NET, breaking-api
>             Fix For: 2.0
>
>
> Current legacy behavior calculates hash codes by calling Object.GetHashCode(), but equality comparison is performed by comparing byte arrays in binary form, which is inconsistent and can lead to unexpected behavior with user-defined keys.
> In 2.0 we should replace default behavior with ArrayResolver so that Equals and GetHashCode are consistent.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)