ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vyacheslav Daradur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-4211) Update Spring dependency to latest stable version
Date Thu, 23 Mar 2017 06:00:47 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937782#comment-15937782

Vyacheslav Daradur commented on IGNITE-4211:

I knew about spring-aop-methods before, but I couldn't understand what you want.

bq. What?
As I've written here before, I think we have to cover with the all new code unit tests, if
possible and where necessary.

I've added the new get-method.
public <T> T get(Object key, Callable<T> valueLoader)

And I think we have to tests the following cases:
- valueLoader parameter calls only once per same key;
- if cache contain nothing for key, result of valueLoader parameter will added to cache correctly;
- if valueLoader parameter throws some exceptions, new get-method rethrow the excepted type
of exception;

These are main cases wich described in the java-docs on the new method.
All cases above were checked in the unit-tests which you don't like.

bq. Why?
Just make that the any get-methods returned "null".
What happens? - Nothing. Green light in the GridSpringCacheManagerSelfTest.
Tests in the GridSpringCacheManagerSelfTest don't check correct behavior of get-methods.
Maybe I'm wrong and returned value are checked in the other tests. (other cases of behavior?)

If you don't agree with my approach, and if the test of @Cachenable(sync=true) is enough for
Just write it, I will change the test and then it's done.
Such simple task was delayed for a long time.

> Update Spring dependency to latest stable version
> -------------------------------------------------
>                 Key: IGNITE-4211
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4211
>             Project: Ignite
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 1.7
>            Reporter: Sergey Kozlov
>            Assignee: Vyacheslav Daradur
>             Fix For: 2.0
> It seems the Spring dependency looks outdated for now. Apache Ignite still uses 4.1.0
released two years ago. Could we to update to latest stable version (4.3.4 at the moment)?

This message was sent by Atlassian JIRA

View raw message