ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anton Vinogradov (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IGNITE-4211) Update Spring dependency to latest stable version
Date Wed, 15 Mar 2017 09:58:41 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925823#comment-15925823
] 

Anton Vinogradov edited comment on IGNITE-4211 at 3/15/17 9:58 AM:
-------------------------------------------------------------------

[~daradurvs]

1) Please add new test to GridSpringCacheManagerSelfTest.
Test should check that @Cacheable(sync=true) works correct. 
Use 10 threads & 1000 (for 1 -> 1000) entries to check this. 
Use latches or another sync to make sure threads will call "get" simultaneously.

2) I thinks we can optimize Spring's JCache solution. No need to use EntryProcessor each time.

Lets use EntryProcessor only when cache contains nothing for a key.

3) Also I see changes at 
private static ValueWrapper fromValue(Object val) 
{noformat)
-        return new SimpleValueWrapper(NULL.equals(val) ? null : val);
 +        return new SimpleValueWrapper(fromStoreValue(val));
{noformat}

please explain this.


was (Author: avinogradov):
[~daradurvs]

1) Please add new test to GridSpringCacheManagerSelfTest.
Test should check that @Cacheable(sync=true) works correct. 
Use 10 threads & 1000 (for 1 -> 1000) entries to check this. 
Use latches or another sync to make sure threads will call "get" simultaneously.

2) I thinks we can optimize Spring's JCache solution. No need to use EntryProcessor each time.

Lets use EntryProcessor only when cache contains nothing for a key.

3) Also I see changes at 
private static ValueWrapper fromValue(Object val) {
{noformat)
-        return new SimpleValueWrapper(NULL.equals(val) ? null : val);
 +        return new SimpleValueWrapper(fromStoreValue(val));
{noformat}

please explain this.

> Update Spring dependency to latest stable version
> -------------------------------------------------
>
>                 Key: IGNITE-4211
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4211
>             Project: Ignite
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 1.7
>            Reporter: Sergey Kozlov
>            Assignee: Vyacheslav Daradur
>             Fix For: 2.0
>
>
> It seems the Spring dependency looks outdated for now. Apache Ignite still uses 4.1.0
released two years ago. Could we to update to latest stable version (4.3.4 at the moment)?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message