ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Valentin Kulichenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-13) String marshalling can be optimized for binary marshaller
Date Sat, 11 Mar 2017 17:33:04 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906259#comment-15906259
] 

Valentin Kulichenko commented on IGNITE-13:
-------------------------------------------

Result do not prove that this change makes sense. Closing the ticket.

> String marshalling can be optimized for binary marshaller
> ---------------------------------------------------------
>
>                 Key: IGNITE-13
>                 URL: https://issues.apache.org/jira/browse/IGNITE-13
>             Project: Ignite
>          Issue Type: Task
>          Components: binary
>            Reporter: Yakov Zhdanov
>            Assignee: Vadim Opolski
>
> Currently string serialization is done in two steps (see {{BinaryWriterExImpl#doWriteString}}):
> {code}
> strArr = BinaryUtils.strToUtf8Bytes(val); // Encode string into byte array.
> out.writeByteArray(strArr);               // Write byte array into stream.
> {code}
> Probably we can write directly into stream while string is encoded, without intermediate
array. This both reduces memory consumption and eliminates array copy step.
> Need to create a micro benchmark first to check if it gives any improvement.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message