ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vladimir Ozerov (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IGNITE-4693) Add possibility to wrap Java plugin exceptions to .NET plugin exceptions
Date Wed, 15 Feb 2017 10:31:41 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867600#comment-15867600
] 

Vladimir Ozerov edited comment on IGNITE-4693 at 2/15/17 10:31 AM:
-------------------------------------------------------------------

[~ptupitsyn], my comments:
1) {{ExceptionFactory}} must have {{className}} argument. Without it user will  have to define
separate factories for every class even if they share the same code.
2) I would also remove {{IIgnite}} from {{ExceptionFactory}} and rather inject it through
annotations. This will make interface easier provided that {{IIgnite}} will not be needed
in general case. Moreover, what if user will perform a call to some {{IIgnite}} method and
receive another error? I would put all these questions aside by simply removing {{IIgnite}}
from the signature.




was (Author: vozerov):
[~ptupitsyn], my comments:
1) {{ExceptionFactory}} must have "className" argument. Without it user will  have to define
separate factories for every class even if they share the same code.
2) I would also remove {{IIgnite}} from {{ExceptionFactory}} and rather inject it through
annotations. This will make interface easier provided that {{IIgnite}} will not be needed
in general case. Moreover, what if user will perform a call to some {{IIgnite}} method and
receive another error? I would put all these questions aside by simply removing {{IIgnite}}
from the signature.



> Add possibility to wrap Java plugin exceptions to .NET plugin exceptions
> ------------------------------------------------------------------------
>
>                 Key: IGNITE-4693
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4693
>             Project: Ignite
>          Issue Type: Sub-task
>          Components: platforms
>    Affects Versions: 2.0
>            Reporter: Pavel Tupitsyn
>            Assignee: Pavel Tupitsyn
>              Labels: .NET
>             Fix For: 2.0
>
>
> Plugins with Java part can throw custom Java exceptions, which are mapped to {{IgniteException}}.
We should add a way for plugin authors to map their custom Java exceptions to corresponding
.NET exceptions.
> This can be done by adding {{IPluginProvider.ConvertException}} method and iterating
over plugins in {{ExceptionUtils.GetException}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message