ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yakov Zhdanov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-4626) GridDhtPartitionTopologyImpl refactoring
Date Wed, 01 Feb 2017 10:53:52 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15848226#comment-15848226
] 

Yakov Zhdanov commented on IGNITE-4626:
---------------------------------------

Here are my comments:
# there is concurrency issue - you do not do volatile writes
# I would change part2nodes to List<ClusterNode>[]
# Apply proper copy on write pattern

> GridDhtPartitionTopologyImpl refactoring
> ----------------------------------------
>
>                 Key: IGNITE-4626
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4626
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Konstantin Dudkov
>            Assignee: Konstantin Dudkov
>
> org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtPartitionTopologyImpl#nodes(int,
org.apache.ignite.internal.processors.affinity.AffinityTopologyVersion)
> Need to refactor this method to use Object[] - partId->List<ClusterNode>



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message