ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Semen Boikov (JIRA)" <j...@apache.org>
Subject [jira] (IGNITE-4552) Optimize GridDhtLocalPartition.rmvQueue
Date Mon, 30 Jan 2017 09:59:43 GMT
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

<html xmlns="http://www.w3.org/1999/xhtml"> 
    <head> 
        <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> 
        <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0"
/> <base href="https://issues.apache.org/jira" /> 
        <title>Message Title</title> 
    </head> 
    <body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px;
line-height: 1.429"> 
        <table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse:
collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse:
collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt"> 
            <!-- header here --> 
            <tr> 
                <td id="header-pattern-container" style="padding: 0px; border-collapse:
collapse; padding: 10px 20px"> 
                    <table id="header-pattern" cellspacing="0" cellpadding="0" border="0"
style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt"> 
                        <tr> 
                            <td id="header-avatar-image-container" valign="top" style="padding:
0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px">
<img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-sboikov-02eb3635-1aa3-4fa0-969b-e587314471da"
height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" /> 
                            </td> 
                            <td id="header-text-container" valign="middle" style="padding:
0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size:
14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover"
rel="sboikov" id="email_sboikov" href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=sboikov"
style="color:#3b73af;; color: #3b73af; text-decoration: none">Semen Boikov</a> <strong>edited
a comment</strong> on <a href="https://issues.apache.org/jira/browse/IGNITE-4552"
style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-static-bug-f0f4682b-896c-4866-94e1-382a2d26d27d"
height="16" width="16" border="0" align="absmiddle" alt="Bug" /> IGNITE-4552</a>

                            </td> 
                        </tr> 
                    </table> 
                </td> 
            </tr> 
            <tr> 
                <td id="email-content-container" style="padding: 0px; border-collapse:
collapse; padding: 0 20px"> 
                    <table id="email-content-table" cellspacing="0" cellpadding="0" border="0"
width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt;
border-spacing: 0; border-collapse: separate"> 
                        <tr> 
                            <!-- there needs to be content in the cell for it to render
in some clients --> 
                            <td class="email-content-rounded-top mobile-expand" style="padding:
0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color:
#fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc;
border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px;
line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
                                &nbsp;
                            </td> 
                        </tr> 
                        <tr> 
                            <td class="email-content-main mobile-expand " style="padding:
0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc;
border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff"> 
                                <table class="page-title-pattern" cellspacing="0" cellpadding="0"
border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace:
0pt"> 
                                    <tr> 
                                        <td style="vertical-align: top;; padding: 0px;
border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule:
exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header"
style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise:
2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.apache.org/jira/browse/IGNITE-4552"
style="color: #3b73af; text-decoration: none">Re: Optimize GridDhtLocalPartition.rmvQueue</a>
</span> 
                                        </td> 
                                    </tr> 
                                </table> 
                            </td> 
                        </tr> 
                        <tr> 
                            <td id="text-paragraph-pattern-top" class="email-content-main
mobile-expand  comment-top-special-margin comment-top-pattern" style="padding: 0px; border-collapse:
collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom:
0; padding: 0 15px 0 16px; background-color: #fff; border-bottom: none; padding-bottom: 0">

                                <table class="text-paragraph-pattern" cellspacing="0" cellpadding="0"
border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace:
0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule:
exactly; mso-text-raise: 2px"> 
                                    <tr> 
                                        <td class="text-paragraph-pattern-container mobile-resize-text
" style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0; padding-top: 10px">
<span class="diffcontext">Hi&nbsp;Evgeny,<br /><br />Do&nbsp;I&nbsp;understand&nbsp;correctly&nbsp;that&nbsp;pictures&nbsp;you&nbsp;attached&nbsp;show&nbsp;that&nbsp;with&nbsp;single&nbsp;node&nbsp;new&nbsp;version&nbsp;is&nbsp;slower?&nbsp;We&nbsp;can&nbsp;not&nbsp;afford&nbsp;this.&nbsp;Also&nbsp;please&nbsp;provide&nbsp;more&nbsp;details&nbsp;about&nbsp;benchmark&nbsp;(type&nbsp;of&nbsp;cache,&nbsp;number&nbsp;of&nbsp;threads,&nbsp;etc),&nbsp;average&nbsp;value&nbsp;also&nbsp;will&nbsp;help&nbsp;to&nbsp;interpret&nbsp;results.&nbsp;Also&nbsp;I&nbsp;do&nbsp;not&nbsp;see&nbsp;your&nbsp;benchmark&nbsp;in&nbsp;ignite-4552,&nbsp;please&nbsp;commit&nbsp;it&nbsp;as&nbsp;well.<br
/><br />Comments&nbsp;regarding&nbsp;changes:&nbsp;you&nbsp;introduced&nbsp;'sycnronized'&nbsp;method&nbsp;GridDhtLocalPartition.putIfRemain,&nbsp;thus&nbsp;we&nbsp;have&nbsp;huge&nbsp;point&nbsp;of&nbsp;contention&nbsp;on&nbsp;remove&nbsp;operation.&nbsp;Let's&nbsp;change&nbsp;it&nbsp;this&nbsp;way:<br
/>-&nbsp;replace&nbsp;LinkedBlockingQueue&nbsp;with&nbsp;ConcurrentLinkedDeque8<br
/>-&nbsp;do&nbsp;not&nbsp;use&nbsp;T3&lt;KeyCacheObject,&nbsp;GridCacheVersion,&nbsp;Long&gt;,&nbsp;add&nbsp;special&nbsp;class&nbsp;to&nbsp;avoid&nbsp;unnecessary&nbsp;boxing&nbsp;for&nbsp;Long<br
/>-&nbsp;in&nbsp;onDeferredDelete:&nbsp;<br /></span> <span
class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">&nbsp;&nbsp;&nbsp;&nbsp;-</span>
<span class="diffaddedchars" style="background-color:#ddfade;">1.</span> <span
class="diffcontext">&nbsp;put&nbsp;new&nbsp;item&nbsp;in&nbsp;queue,&nbsp;<br
/></span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">&nbsp;&nbsp;&nbsp;&nbsp;-</span>
<span class="diffaddedchars" style="background-color:#ddfade;">2.</span> <span
class="diffcontext">&nbsp;while&nbsp;queue.peekFirst.expireTime&nbsp;&gt;&nbsp;'current&nbsp;time'&nbsp;remove&nbsp;it&nbsp;from&nbsp;queue<br
/></span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">&nbsp;&nbsp;&nbsp;&nbsp;-</span>
<span class="diffaddedchars" style="background-color:#ddfade;">3.</span> <span
class="diffcontext">&nbsp;if&nbsp;queue.sizex&nbsp;&gt;&nbsp;LIMIT&nbsp;remove&nbsp;items&nbsp;from&nbsp;queue<br
/>-&nbsp;let's&nbsp;get&nbsp;rid&nbsp;of&nbsp;new&nbsp;cleanup&nbsp;thread,&nbsp;instead&nbsp;schedule&nbsp;periodic&nbsp;task&nbsp;using&nbsp;GridTimeoutProcessor.&nbsp;This&nbsp;task&nbsp;should&nbsp;submit&nbsp;another&nbsp;cleanup&nbsp;runnable&nbsp;is&nbsp;system&nbsp;pool:&nbsp;cctx.closures().runLocalSafe(c,&nbsp;true)&nbsp;(GridTimeoutProcessor's&nbsp;task&nbsp;itself&nbsp;should&nbsp;not&nbsp;execute&nbsp;long&nbsp;operations&nbsp;since&nbsp;all&nbsp;tasks&nbsp;in&nbsp;GridTimeoutProcessor&nbsp;are&nbsp;processed&nbsp;by&nbsp;single&nbsp;thread)<br
/>-&nbsp;we&nbsp;need&nbsp;disable&nbsp;'clear&nbsp;rmv&nbsp;queue&nbsp;by&nbsp;time'&nbsp;if&nbsp;data&nbsp;center&nbsp;replication&nbsp;is&nbsp;enabled&nbsp;(GridCacheDrManager.enabled()),&nbsp;in&nbsp;this&nbsp;case&nbsp;only&nbsp;'clear&nbsp;by&nbsp;max&nbsp;queue&nbsp;size'&nbsp;should&nbsp;work<br
/><br />Thanks!</span> 
                                        </td> 
                                    </tr> 
                                </table> 
                            </td> 
                        </tr> 
                        <tr> 
                            <td class="email-content-main mobile-expand " style="padding:
0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc;
border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff"> 
                                <table id="actions-pattern" cellspacing="0" cellpadding="0"
border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace:
0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule:
exactly; mso-text-raise: 1px"> 
                                    <tr> 
                                        <td id="actions-pattern-container" valign="middle"
style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align:
middle; padding-left: 0"> 
                                            <table align="left" style="border-collapse:
collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt"> 
                                                <tr> 
                                                    <td class="actions-pattern-action-icon-container"
style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size:
14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align:
middle"> <a href="https://issues.apache.org/jira/browse/IGNITE-4552#add-comment" target="_blank"
title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image"
src="cid:jira-generated-image-static-comment-icon-2d11b723-d75c-47fc-9298-8cc8d5d25d03" alt="Add
Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"
/> </a> 
                                                    </td> 
                                                    <td class="actions-pattern-action-text-container"
style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size:
14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left:
5px"> <a href="https://issues.apache.org/jira/browse/IGNITE-4552#add-comment" target="_blank"
title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>

                                                    </td> 
                                                </tr> 
                                            </table> 
                                        </td> 
                                    </tr> 
                                </table> 
                            </td> 
                        </tr> 
                        <!-- there needs to be content in the cell for it to render in
some clients --> 
                        <tr> 
                            <td class="email-content-rounded-bottom mobile-expand" style="padding:
0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height:
5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px
solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius:
5px; mso-line-height-rule: exactly">
                                &nbsp;
                            </td> 
                        </tr> 
                    </table> 
                </td> 
            </tr> 
            <tr> 
                <td id="footer-pattern" style="padding: 0px; border-collapse: collapse;
padding: 12px 20px"> 
                    <table id="footer-pattern-container" cellspacing="0" cellpadding="0"
border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">

                        <tr> 
                            <td id="footer-pattern-text" class="mobile-resize-text" width="100%"
style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height:
18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
                                 This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.3.15#6346-<span
title="dbc023dd75cecacf443c4b235f66124b15f5c5fe" data-commit-id="dbc023dd75cecacf443c4b235f66124b15f5c5fe}">sha1:dbc023d</span>)</span>

                            </td> 
                            <td id="footer-pattern-logo-desktop-container" valign="top"
style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">

                                <table style="border-collapse: collapse; mso-table-lspace:
0pt; mso-table-rspace: 0pt"> 
                                    <tr> 
                                        <td id="footer-pattern-logo-desktop-padding" style="padding:
0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop"
src="cid:jira-generated-image-static-footer-desktop-logo-de3fdce9-6d5c-47ef-81a2-1446f8222605"
alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />

                                        </td> 
                                    </tr> 
                                </table> 
                            </td> 
                        </tr> 
                    </table> 
                </td> 
            </tr> 
        </table>   
    </body>
</html>
Mime
View raw message