ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vyacheslav Daradur (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IGNITE-4374) Ignite should validate JVM and OS configuration and output warning in log
Date Thu, 26 Jan 2017 14:55:24 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-4374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839693#comment-15839693
] 

Vyacheslav Daradur edited comment on IGNITE-4374 at 1/26/17 2:54 PM:
---------------------------------------------------------------------

[~yzhdanov], [~dmagda],

I like the idea to place code of checks on different classes, because they check different
things and they have own output format. It is easy to add new checks.

I don't like the idea to add additional sections in GridConfigurationSuggestions.

I think to give just the reference to the readme.io page – is the bad idea, because if someone
to change article it will be necessary to change the code. (e.g. someone remove an option
from article which is checked)

I think there are 2 ways:

*1.* (I don't like it)
1.1 We will make output less detailed
1.2 Move  JVM and OS checks to IgniteKernal
1.3 Rename GridConfigurationSuggestions to ConfigurationSugestions

*2.* 
bq. Moreover, they use single system property to disable the output.
- we can add another a class, which will control output of all suggestions;
- or add another system properties to disable output of JVM and OS suggections;
- or remove this flag from suggestions classes and to check it only in IgniteKernal, where
we invoke #logSuggestions;

--
The output example consists all checks, actually the output will be less.
I need to understand what output you want to see, because I think the current output isn't
overloaded.


was (Author: daradurvs):
[~yzhdanov], [~dmagda],

I like the idea to place code of checks on different classes, because they check different
things and they have own output format. It is easy to add new checks.

I don't like the idea to add additional sections in GridConfigurationSuggestions.

I think to give just the reference to the readme.io page – is the bad idea, because if someone
to change article it will be necessary to change the code. (e.g. someone remove an option
from article which is checked)

I think there are 2 ways:

*1.* (I don't like it)
1.1 We will make output less detailed
1.2 Move  JVM and OS checks to IgniteKernal
1.3 Rename GridConfigurationSuggestions to ConfigurationSugestions

*2.* 
bq. Moreover, they use single system property to disable the output.
- we can add another a class, which will control output of all suggestions;
- or add another system properties to disable output of JVM and OS suggections;
- or remove this flag from suggestions classes and to check it only in IgniteKernal, where
we invoke #logSuggestions;
--
The output example consists all checks, actually the output will be less.
I need to understand what output you want to see, because I think the current output isn't
overloaded.

> Ignite should validate JVM and OS configuration and output warning in log
> -------------------------------------------------------------------------
>
>                 Key: IGNITE-4374
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4374
>             Project: Ignite
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Yakov Zhdanov
>            Assignee: Vyacheslav Daradur
>         Attachments: x32_not_optimized.png, x32_optimized.png, x64_not_optimized.png,
x64_optimized.png
>
>
> Currently we have GridPerformanceSuggestions that output suggestions to logs on Ignite
start on how Ignite can be improved.
> I suggest to go a little bit deeper and validate more configuration options and add validation
for JVM and OS settings.
> Ignite should output warning if:
> * GC logging is not enabled
> * MaxDirectMemorySize is not set (-XX:MaxDirectMemorySize)
> * Heap size is greater than 30,5G and JVM cannot use compressed oops
> * Any of the recommended OS setting described here https://apacheignite.readme.io/docs/jvm-and-system-tuning
are not properly set 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message