ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Tupitsyn (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IGNITE-4046) C++: Support DML API
Date Tue, 17 Jan 2017 09:00:38 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-4046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15825663#comment-15825663
] 

Pavel Tupitsyn edited comment on IGNITE-4046 at 1/17/17 8:59 AM:
-----------------------------------------------------------------

Igor, my main concern is about {{BinaryArrayIdentityResolver}} efficiency: we do the same
thing twice when writing an object to a stream in {{BinaryWriterImpl::WriteTopObject}} (allocate
temp stream, write to temp stream to get the hash code, then write to the main stream).

Binary writer is on a very hot path, so I think we should get rid of temporary stream and
calculate the hash code using the main stream. Ignite.NET works this way.

Also please add separate unit tests for {{BinaryArrayIdentityResolver}} and {{GetDataHashCode}}.


was (Author: ptupitsyn):
Igor, my main concern is about BinaryArrayIdentityResolver efficiency: we do the same thing
twice when writing an object to a stream in {{BinaryWriterImpl::WriteTopObject}} (allocate
temp stream, write to temp stream to get the hash code, then write to the main stream).

Binary writer is on a very hot path, so I think we should get rid of temporary stream and
calculate the hash code using the main stream. Ignite.NET works this way.

Also please add separate unit tests for {{BinaryArrayIdentityResolver}} and {{GetDataHashCode}}.

> C++: Support DML API
> --------------------
>
>                 Key: IGNITE-4046
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4046
>             Project: Ignite
>          Issue Type: Task
>          Components: platforms
>    Affects Versions: 1.8
>            Reporter: Denis Magda
>            Assignee: Pavel Tupitsyn
>              Labels: roadmap
>             Fix For: 1.9
>
>
> Ignite's Java component will provide support for DML soon (IGNITE-2294). At she same
time DML will be supported at the level of ODBC and JDBC drivers.
> As the next step we should include the similar functionality into Ignite.C++ by doing
the following:
> - Implement DML API;
> - Enhance {{query_example.cpp}} by doing INSERTs instead of cache.puts and adding UPDATE
and DELETE operation examples.
> - Add documentation to Ignite.C++ readme.io covering the feature. Most like most of the
content can be take from the general documentation when this ticket IGNITE-4018 is ready.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message