ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vladimir Ozerov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-3625) IGFS: Use common naming for IGFS meta and data caches.
Date Thu, 19 Jan 2017 12:29:26 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829822#comment-15829822

Vladimir Ozerov commented on IGNITE-3625:


Looks good to me. I made several minor corrections and merged with {{ignite-2.0}} branch.
The only thing I am concerned about is changes to Visor classes. Could you please ask Visor
experts, e.g. [~kuaw26] to review them? 

Also I would perform another IGFS/Hadoop tests run since lots of changes were merged from

> IGFS: Use common naming for IGFS meta and data caches.
> ------------------------------------------------------
>                 Key: IGNITE-3625
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3625
>             Project: Ignite
>          Issue Type: Task
>          Components: IGFS
>    Affects Versions: 1.6
>            Reporter: Vladimir Ozerov
>            Assignee: Taras Ledkov
>             Fix For: 2.0
> Currently IGFS is configured by passing names of two caches: meta and data. See {{FileSystemConfiguration.metaCacheName}}
and {{FileSystemConfiguration.dataCacheName}}.
> These two caches are considered internal then and are not accessible for the user.
> We need to do the following during node startup:
> 1) If certain cache is configured as meta or data cache for multiple IGFS-es, or if it
is configured as both meta and data cache for a single IGFS, then throw an exception.
> Relevant code pieces:
> {{IgfsProcessor.validateLocalIgfsConfigurations}}
> {{IgfsProcessorSelfTest}}.
> 2) During node startup change the name of this cache to {{igfs-IGFS_NAME-meta}} or {{igfs-IGFS_NAME-data}}.
Change must be performed both inside IGFS config and cache config.
> Relevant code pieces:
> {{CacheConfiguration.name}}
> {{FileSystemConfiguration.metaCacheName}}
> {{FileSystemConfiguration.dataCacheName}}
> {{IgfsUtils.prepareCacheConfiguration}} - where change will be done.
> 3) If any of new names caches with any other cache name, an exception should be thrown.
The most simple way: throw an exception if user-configured cache name starts with {{igfs-}}
and ends with {{-meta}} or {{-data}}.
> Relevant code pieces:
> {{IgniteNamedInstance.initializeDefaultCacheConfiguration}}.

This message was sent by Atlassian JIRA

View raw message