ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vladimir Ozerov (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IGNITE-481) Add tests for Metrics to the file system tests infrastructure
Date Thu, 26 Jan 2017 10:11:24 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839481#comment-15839481
] 

Vladimir Ozerov edited comment on IGNITE-481 at 1/26/17 10:10 AM:
------------------------------------------------------------------

Ivan,
I merged latest changes to the ticket. Pleas update your branch. My comments:
1) {{IgfsOutputStreamProxyImpl.send}} - block number calculation looks wrong to me. Consider
that I have a block size = 10. Then I write chunk of 5 bytes, and then 15 bytes. I written
two blocks, but current logic will think that I wrote 3 blocks. 
2) {{IgfsImpl.update}} - why do you perform additional OS call to {{secondaryFs.info}} while
{{secondaryFs.update}} already returns it?
3) Something is wrong with {{IgfsFileInfo}} constructors still. Please review all their usages
thoroughly.


was (Author: vozerov):
Ivan,
I merged latest changes to the ticket. Pleas update your branch. My comments:
1) {{IgfsOutputStreamProxyImpl.send}} - block number calculation looks wrong to me. Consider
that I have a block size = 10. Then I write chunk of 5 bytes, and then 15 bytes. I written
two blocks, but current logic will think that I wrote 3 blocks. 
2) {{IgfsImpl.update}} - why do you perform additional OS call to {{secondaryFs.info}] while
{{secondaryFs.update}} already returns it?
3) Something is wrong with {{IgfsFileInfo}} constructors still. Please review all their usages
thoroughly.

> Add tests for Metrics to the file system tests infrastructure
> -------------------------------------------------------------
>
>                 Key: IGNITE-481
>                 URL: https://issues.apache.org/jira/browse/IGNITE-481
>             Project: Ignite
>          Issue Type: Task
>          Components: IGFS
>    Affects Versions: 1.6
>            Reporter: Ivan Veselovsky
>            Assignee: Ivan Veselovsky
>            Priority: Minor
>             Fix For: 1.9
>
>
> Need to add tests for org.apache.ignite.igfs.IgfsMetrics to the filesystem tests.
> See org.apache.ignite.IgniteFileSystem#metrics , 
> org.apache.ignite.IgniteFileSystem#resetMetrics .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message