Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B21D4200BEB for ; Wed, 14 Dec 2016 00:52:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B0C3C160B23; Tue, 13 Dec 2016 23:52:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2AAF7160B31 for ; Wed, 14 Dec 2016 00:52:00 +0100 (CET) Received: (qmail 36034 invoked by uid 500); 13 Dec 2016 23:51:58 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 35757 invoked by uid 99); 13 Dec 2016 23:51:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Dec 2016 23:51:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 86F362C03E5 for ; Tue, 13 Dec 2016 23:51:58 +0000 (UTC) Date: Tue, 13 Dec 2016 23:51:58 +0000 (UTC) From: "Rohit Mohta (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-4358) Better error reporting in case of unmarshallable classes. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 13 Dec 2016 23:52:00 -0000 [ https://issues.apache.org/jira/browse/IGNITE-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15746656#comment-15746656 ] Rohit Mohta commented on IGNITE-4358: ------------------------------------- [~ascherbakov] Changed the message per your comment. NPE check was present in my earlier patch too. ``` Objects.requireNonNull(r, "Trying to execute a null closure. Make sure the closure is not assignable from classes listed in MarshallerExclusions"); ``` > Better error reporting in case of unmarshallable classes. > --------------------------------------------------------- > > Key: IGNITE-4358 > URL: https://issues.apache.org/jira/browse/IGNITE-4358 > Project: Ignite > Issue Type: Improvement > Components: compute, messaging, newbie > Affects Versions: 1.6 > Reporter: Alexei Scherbakov > Assignee: Rohit Mohta > Priority: Trivial > Labels: newbie > Fix For: 2,0 > > Attachments: IGNITE-4358-Exceptionlog-05Dec2016.txt, IGNITE-4358-GridClosureProcessor-05Dec2016.patch, PureIgniteRunTest.java > > > When trying to execute Thread's derived class implementing IgniteRunnable using compute API, it silently serializes to null because Thread serialization is prohibited in MarshallerExclusions and throws NPE on executing node. > We need to throw more informative exception for such case. > Reproducer in the attachment. -- This message was sent by Atlassian JIRA (v6.3.4#6332)