Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3A31E200BE4 for ; Wed, 21 Dec 2016 14:37:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 38B84160B26; Wed, 21 Dec 2016 13:37:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 849DF160B0C for ; Wed, 21 Dec 2016 14:36:59 +0100 (CET) Received: (qmail 57765 invoked by uid 500); 21 Dec 2016 13:36:58 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 57756 invoked by uid 99); 21 Dec 2016 13:36:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Dec 2016 13:36:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7C0022C0059 for ; Wed, 21 Dec 2016 13:36:58 +0000 (UTC) Date: Wed, 21 Dec 2016 13:36:58 +0000 (UTC) From: "Andrew Mashenkov (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (IGNITE-4142) Assertion in ClientImpl.updateMetrics() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 21 Dec 2016 13:37:00 -0000 [ https://issues.apache.org/jira/browse/IGNITE-4142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Mashenkov reassigned IGNITE-4142: ---------------------------------------- Assignee: Andrew Mashenkov > Assertion in ClientImpl.updateMetrics() > --------------------------------------- > > Key: IGNITE-4142 > URL: https://issues.apache.org/jira/browse/IGNITE-4142 > Project: Ignite > Issue Type: Bug > Components: general > Affects Versions: 1.7 > Reporter: Valentin Kulichenko > Assignee: Andrew Mashenkov > Priority: Critical > Fix For: 2.0 > > > The problem was reported here: http://apache-ignite-users.70518.x6.nabble.com/AssertionError-td8321.html > It looks like the reason is that {{TcpDiscoveryHeartbeatMessage.setCacheMetrics()}} method does not put empty map in the {{cacheMetrics}} collection. As a result, it's possible that there are cluster metrics for a node, but no cache metrics for this node - this leads to the assertion in {{ClientImpl.updateMetrics}} (see below). We should remove the {{if}} in {{TcpDiscoveryHeartbeatMessage.setCacheMetrics()}} or change {{ClientImpl.updateMetrics}} logic so that it does not fail in this case. > We should also try to reproduce in a unit test to make sure this the only problematic code here. > {noformat} > 10:39:38,355 SEVERE [TcpDiscoverySpi] Runtime error caught during grid runnable execution: IgniteSpiThread [name=tcp-client-disco-msg-worker-#4%FooGrid%]: java.lang.AssertionError > at org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.updateMetrics(ClientImpl.java:2046) > at org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.processHeartbeatMessage(ClientImpl.java:1926) > at org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.processDiscoveryMessage(ClientImpl.java:1580) > at org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.body(ClientImpl.java:1499) > at org.apache.ignite.spi.IgniteSpiThread.run(IgniteSpiThread.java:62) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)