ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-4142) Assertion in ClientImpl.updateMetrics()
Date Wed, 21 Dec 2016 16:51:58 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-4142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767529#comment-15767529
] 

ASF GitHub Bot commented on IGNITE-4142:
----------------------------------------

GitHub user AMashenkov opened a pull request:

    https://github.com/apache/ignite/pull/1370

    IGNITE-4142: Assertion in ClientImpl.updateMetrics()

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-4142

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/1370.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1370
    
----
commit c188c3c4a96eacb85ea8e08f0634288332432c1c
Author: Alexey Kuznetsov <akuznetsov@apache.org>
Date:   2016-09-28T01:46:23Z

    IGNITE-3983 Fixed wrong cache load optimization. Test added.

commit 89c30c8b0be6915d2399be508ddcd9eb439a9aaa
Author: Alexey Kuznetsov <akuznetsov@apache.org>
Date:   2016-09-28T01:57:45Z

    IGNITE-3965 @GridInternal tasks should run via standart LoadBalancingSpi. Added test.

commit a53c399e10926120106379d1c764edd7d3854e6a
Author: Alexey Kuznetsov <akuznetsov@apache.org>
Date:   2016-09-28T02:07:55Z

    Merge ignite-1.6.9 into ignite-1.7.2.

commit ec9ddcd3d99d19403bf19e1172ede2afdab6c86f
Author: sboikov <sboikov@gridgain.com>
Date:   2016-09-28T09:05:28Z

    Code style fixes.

commit 17c2fc0b69abd023b2a1e5da344e67951fd49408
Author: sboikov <sboikov@gridgain.com>
Date:   2016-09-28T09:56:17Z

    ignite-2833 Need call 'touch' for cache entry if it was obtained using 'entryEx'.

commit daf974d261efa525678d5fabc6191642c07f9ad4
Author: AKuznetsov <akuznetsov@gridgain.com>
Date:   2016-09-28T10:22:10Z

    IGNITE-3965 Fixed issues found on review.

commit 53fbad7ddafdae7b368b0f207d06d16574978d62
Author: AKuznetsov <akuznetsov@gridgain.com>
Date:   2016-09-28T10:24:56Z

    Merge branch ignite-1.6.9 into ignite-1.7.2.

commit 4ff19c20b169e0373eafc8025a838db8bfc61f27
Author: sboikov <sboikov@gridgain.com>
Date:   2016-09-28T10:47:51Z

    ignite-3621 Fixed 'testEvictExpired'.

commit bfe4458448a59542713830f57713b3ac2af08e2b
Author: sboikov <sboikov@gridgain.com>
Date:   2016-09-28T11:31:24Z

    ignite-3621 Fixed 'testEvictExpired'.

commit d643dcf2dd2caac4c3ff04cb72f31bbfbf97339a
Author: Pavel Tupitsyn <ptupitsyn@apache.org>
Date:   2016-09-28T11:34:23Z

    IGNITE-3970 .NET: Fix Cyrillic 'C' letters in code - add test

commit 474ade276c4ae3e8f93cce37473d37270b4e7ad9
Author: vozerov-gridgain <vozerov@gridgain.com>
Date:   2016-09-28T11:38:04Z

    IGNITE-3988: Moved failing cloud tests to ignore module.

commit ccfaaf8d060ef984678d2376b16b5a17e7c17e9d
Author: vozerov-gridgain <vozerov@gridgain.com>
Date:   2016-09-28T11:38:17Z

    Merge remote-tracking branch 'upstream/ignite-1.6.9' into ignite-1.6.9

commit c7fa918c10d771efa91cde1017662c26d0a61085
Author: Pavel Tupitsyn <ptupitsyn@apache.org>
Date:   2016-09-28T11:47:17Z

    Merge remote-tracking branch 'remotes/community/ignite-1.6.9' into ignite-1.7.3

commit b9105df77cc70b532f94899c754fba47e3e05e9a
Author: vozerov-gridgain <vozerov@gridgain.com>
Date:   2016-09-28T11:53:20Z

    IGNITE-3989: Moved failing JTA tests to ignore module.

commit d595345765db2151ff432beecd478ce056393593
Author: vozerov-gridgain <vozerov@gridgain.com>
Date:   2016-09-28T12:08:38Z

    IGNITE-3990: Moved failing Spring tests to "ignore" module.

commit e3f13455d4273e615727d0410783e3719db98f76
Author: sboikov <sboikov@gridgain.com>
Date:   2016-09-28T09:56:17Z

    ignite-2833 Need call 'touch' for cache entry if it was obtained using 'entryEx'.
    
    (cherry picked from commit 17c2fc0)

commit b2faa339acb2eea24e6dd5e0c21fc3d3d0592ff6
Author: sboikov <sboikov@gridgain.com>
Date:   2016-09-28T10:47:51Z

    ignite-3621 Fixed 'testEvictExpired'.
    
    (cherry picked from commit 4ff19c2)

commit 74d2fc2416b8e6bc0598152552021f984a013061
Author: sboikov <sboikov@gridgain.com>
Date:   2016-09-28T11:31:24Z

    ignite-3621 Fixed 'testEvictExpired'.
    
    (cherry picked from commit bfe4458)

commit d2563dacceea61b19bb6e083e29ebacc28fdd323
Author: vozerov-gridgain <vozerov@gridgain.com>
Date:   2016-09-28T12:51:55Z

    IGNITE-3993: Added failing client tests to "ignored" test suite.

commit 33d34941390c00e8d6a2488e8f2e11e6abba8a01
Author: sboikov <sboikov@gridgain.com>
Date:   2016-09-28T12:54:52Z

    Merge remote-tracking branch 'community/ignite-1.6.9' into ignite-1.6.9

commit 78144c4c9d6200ceef8b666a186039685f053381
Author: vozerov-gridgain <vozerov@gridgain.com>
Date:   2016-09-28T13:52:13Z

    Fixed incorrect test count calculation leading to afterTestsStopped() not being called.

commit e3dfdecc3607b5f3183bfcb1ce36c57543a8965f
Author: Alexander Paschenko <alexander.a.paschenko@gmail.com>
Date:   2016-09-28T13:46:46Z

    Validate hash code presence in BinaryObject. Fixes #928

commit 53229e290f7d6aab9b504693bd2b93155ecd2bad
Author: Pavel Tupitsyn <ptupitsyn@gridgain.com>
Date:   2016-09-28T14:07:47Z

    IGNITE-3995 .NET: Introduced default non-null ASP.NET Session-State Store Provider cache
name. This closes #1128.

commit d1e3a78ae569fa5d5692816db44f2c677e1b8283
Author: Valentin Kulichenko <valentin.lulichenko@gmail.com>
Date:   2016-09-29T00:53:42Z

    IGNITE-3191 - Fixed ordering of fields in binary objects

commit b280c3efa1eb84c6bc8abbe31ba669b0c24323d8
Author: vozerov-gridgain <vozerov@gridgain.com>
Date:   2016-09-29T07:23:54Z

    Fixed missing Apache header.

commit 3e8a1c6b045c231dbb3c972463000f824386aee9
Author: vozerov-gridgain <vozerov@gridgain.com>
Date:   2016-09-29T08:08:23Z

    Added node stop to IgniteCacheExpireAndUpdateConsistencyTest.

commit 062b9b69aa851d5253dfb7f44066b7d749f1ca12
Author: Alexey Goncharuk <alexey.goncharuk@gmail.com>
Date:   2016-09-29T08:26:50Z

    IGNITE-3633 - Enforce key validation for tests.

commit a4d7aa343df23a5e00df11c5080cc1762b187161
Author: sboikov <sboikov@gridgain.com>
Date:   2016-09-29T09:04:44Z

    ignite-3621 Fixed 'testEvictExpired'.

commit ad613afd7165ed2d8bf0a62805fc2506dfe6c59a
Author: sboikov <sboikov@gridgain.com>
Date:   2016-09-29T09:04:44Z

    ignite-3621 Fixed 'testEvictExpired'.
    
    (cherry picked from commit a4d7aa3)

commit 22dc2c9e05e5183f838865023c9cb7a8291ac67f
Author: Alexander Paschenko <alexander.a.paschenko@gmail.com>
Date:   2016-09-29T12:43:20Z

    GridNearCacheAdapter, GridDhtCacheAdapter - test fix

----


> Assertion in ClientImpl.updateMetrics()
> ---------------------------------------
>
>                 Key: IGNITE-4142
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4142
>             Project: Ignite
>          Issue Type: Bug
>          Components: general
>    Affects Versions: 1.7
>            Reporter: Valentin Kulichenko
>            Assignee: Andrew Mashenkov
>            Priority: Critical
>             Fix For: 2.0
>
>
> The problem was reported here: http://apache-ignite-users.70518.x6.nabble.com/AssertionError-td8321.html
> It looks like the reason is that {{TcpDiscoveryHeartbeatMessage.setCacheMetrics()}} method
does not put empty map in the {{cacheMetrics}} collection. As a result, it's possible that
there are cluster metrics for a node, but no cache metrics for this node - this leads to the
assertion in {{ClientImpl.updateMetrics}} (see below). We should remove the {{if}} in {{TcpDiscoveryHeartbeatMessage.setCacheMetrics()}}
or change {{ClientImpl.updateMetrics}} logic so that it does not fail in this case.
> We should also try to reproduce in a unit test to make sure this the only problematic
code here.
> {noformat}
> 10:39:38,355 SEVERE [TcpDiscoverySpi] Runtime error caught during grid runnable execution:
IgniteSpiThread [name=tcp-client-disco-msg-worker-#4%FooGrid%]: java.lang.AssertionError 
>         at org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.updateMetrics(ClientImpl.java:2046)

>         at org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.processHeartbeatMessage(ClientImpl.java:1926)

>         at org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.processDiscoveryMessage(ClientImpl.java:1580)

>         at org.apache.ignite.spi.discovery.tcp.ClientImpl$MessageWorker.body(ClientImpl.java:1499)

>         at org.apache.ignite.spi.IgniteSpiThread.run(IgniteSpiThread.java:62) 
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message