Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DE339200BC8 for ; Wed, 23 Nov 2016 22:14:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DC99D160AFD; Wed, 23 Nov 2016 21:14:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 326AE160AEC for ; Wed, 23 Nov 2016 22:14:00 +0100 (CET) Received: (qmail 83324 invoked by uid 500); 23 Nov 2016 21:13:59 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 83312 invoked by uid 99); 23 Nov 2016 21:13:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Nov 2016 21:13:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 51DFE2C022B for ; Wed, 23 Nov 2016 21:13:59 +0000 (UTC) Date: Wed, 23 Nov 2016 21:13:59 +0000 (UTC) From: "Denis Magda (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-4293) Deserialized value is cached if queries are enabled MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 23 Nov 2016 21:14:01 -0000 [ https://issues.apache.org/jira/browse/IGNITE-4293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15691381#comment-15691381 ] Denis Magda commented on IGNITE-4293: ------------------------------------- In my understanding all we need to do is to pass {{cfg.isCopyOnRead()}} value instead of {{ctx0.storeValue()}} into this call {code} CacheObjectContext res = new CacheObjectBinaryContext(ctx, cfg.getName(), ctx0.copyOnGet(), ctx0.storeValue(), binaryEnabled, ctx0.addDeploymentInfo()); {code} that is inside of {{CacheObjectBinaryProcessorImpl.contextForCache()}} method. > Deserialized value is cached if queries are enabled > --------------------------------------------------- > > Key: IGNITE-4293 > URL: https://issues.apache.org/jira/browse/IGNITE-4293 > Project: Ignite > Issue Type: Bug > Components: cache > Affects Versions: 1.7 > Reporter: Valentin Kulichenko > Priority: Critical > > Here is the problematic piece of code in {{IgniteCacheObjectProcessorImpl}}: > {code} > boolean storeVal = ctx.config().isPeerClassLoadingEnabled() || > GridQueryProcessor.isEnabled(ccfg) || > !ccfg.isCopyOnRead(); > {code} > This flag is set to true if queries are enabled even when binary marshaller is used (this condition makes sense to other marshallers though). It is then use in {{BinaryObjectImpl.deserializeValue}}: > {code} > if (coCtx != null && coCtx.storeValue()) > obj = obj0; > {code} > As a result, memory consumption doubles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)