ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrey Novikov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-1943) ignitevisorcmd: wrong behavior for "mclear" command
Date Tue, 25 Oct 2016 10:44:58 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15604952#comment-15604952
] 

Andrey Novikov commented on IGNITE-1943:
----------------------------------------

Saikat, I reviewed your pull request and I think this changes lead to inconsistent behavior
for different type of shortcut. Maybe it will be better to remove «mclear» command and introduce
«mcompact» command, that will compact gaps in shortcuts?

> ignitevisorcmd: wrong behavior for "mclear" command
> ---------------------------------------------------
>
>                 Key: IGNITE-1943
>                 URL: https://issues.apache.org/jira/browse/IGNITE-1943
>             Project: Ignite
>          Issue Type: Bug
>          Components: general
>    Affects Versions: 1.5.0.final
>            Reporter: Vasilisa  Sidorova
>            Assignee: Saikat Maitra
>             Fix For: 1.8
>
>
> ---------------------------------------------
> DESCRIPTION
> ---------------------------------------------
> "mclear" should clears all Visor console variables before they will be updated during
next run of the corresponding command. It OK for all type of shortcut (@cX, @tX, @aX, @eX)
exept shortcut for node-id variables. After "mclear" @nX are disappear from any statistics

> ---------------------------------------------
> STEPS FOR REPRODUCE
> ---------------------------------------------
> # Start cluster
> # Start visorcmd ([IGNITE_HOME]/bin/ignitevisorcmd.sh)
> # Connect to the started cluster (visor> open)
> # Execute any tasks in it (for example, run any example from EventsExample, DeploymentExample,
ComputeContinuousMapperExample, ComputeTaskMapExample, ComputeTaskSplitExample) 
> # Create several alerts (visor> alert)
> # Run visor "mclear" command
> # Run visor "node" command
> ---------------------------------------------
> ACTUAL RESULT
> ---------------------------------------------
> There isn't @nX values in the first table's column:
> {noformat}
> visor> node
> Select node from:
> +==================================================================+
> | # |   Node ID8(@), IP   | Up Time  | CPUs | CPU Load | Free Heap |
> +==================================================================+
> | 0 | 6B3E4033, 127.0.0.1 | 00:38:41 | 8    | 0.20 %   | 97.00 %   |
> | 1 | 0A0D6989, 127.0.0.1 | 00:38:22 | 8    | 0.17 %   | 97.00 %   |
> | 2 | 0941E33F, 127.0.0.1 | 00:35:46 | 8    | 0.23 %   | 97.00 %   |
> +------------------------------------------------------------------+
> {noformat}
> ---------------------------------------------
> EXPECTED RESULT
> ---------------------------------------------
> There is @nX values in the first table's column:
> {noformat}
> visor> node
> Select node from:
> +=======================================================================+
> | # |     Node ID8(@), IP      | Up Time  | CPUs | CPU Load | Free Heap |
> +=======================================================================+
> | 0 | 6B3E4033(@n0), 127.0.0.1 | 00:38:13 | 8    | 0.23 %   | 97.00 %   |
> | 1 | 0A0D6989(@n1), 127.0.0.1 | 00:37:54 | 8    | 0.27 %   | 97.00 %   |
> | 2 | 0941E33F(@n2), 127.0.0.1 | 00:35:18 | 8    | 0.20 %   | 97.00 %   |
> +-----------------------------------------------------------------------+
> {noformat}
> "mclear" should get effect only for "mget @nX" command (with result "Missing variable
with name: '@nX'") and @nX variables  should get new values after "node" (or "tasks") command
execution. Like in case for all others @ variables (@cX, @tX, @aX, @eX) 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message