ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-3770) GridLogThrottle.warn ignores the exception
Date Wed, 21 Sep 2016 04:20:20 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15508680#comment-15508680
] 

ASF GitHub Bot commented on IGNITE-3770:
----------------------------------------

GitHub user shroman opened a pull request:

    https://github.com/apache/ignite/pull/1095

    IGNITE-3770: GridLogThrottle.warn ignores the exception.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shroman/ignite ignite-3770

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/1095.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1095
    
----
commit b8b420f4273869eabec48f343649d20d587fc526
Author: shtykh_roman <rshtykh@yahoo.com>
Date:   2016-09-21T04:19:15Z

    IGNITE-3770: GridLogThrottle.warn ignores the exception.

----


> GridLogThrottle.warn ignores the exception
> ------------------------------------------
>
>                 Key: IGNITE-3770
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3770
>             Project: Ignite
>          Issue Type: Bug
>          Components: general
>    Affects Versions: 1.7
>            Reporter: Valentin Kulichenko
>            Assignee: Roman Shtykh
>            Priority: Critical
>             Fix For: 1.8
>
>
> There are two ways to fix this:
> * Make sure that {{warn()}} method prints out the stack trace of the provided exception.
> * Remove exception parameter from the {{warn()}} method and replace all such usages with
{{error()}}.
> I personally think that the second approach is clearer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message