ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrey Gura (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IGNITE-3421) Add ability to configure maxIterCnt property in GridCacheQueryManager
Date Wed, 14 Sep 2016 01:07:20 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-3421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15487693#comment-15487693
] 

Andrey Gura edited comment on IGNITE-3421 at 9/14/16 1:06 AM:
--------------------------------------------------------------

[~roman_s]

Roman, I've reviewed your pull request. Looks good for me. But I think that {{CacheConfiguration.getMaximumQueryIteratorCount()}}
and {{CacheConfiguration.setMaximumQueryIteratorCount()}} should be renamed to {{CacheConfiguration.getMaxQueryIteratorsCount()}}
and {{CacheConfiguration.setMaxQueryIteratorsCount()}} for the sake of uniformity with other
methods' names in {{CacheConfiguration}} class (using {{Max}} word and plural for {{Iterators}}).

Also I'm not sure that we should provide ability to configure maximum iterators count per
cache. May be one system property will be enough for this purposes. What about discussion
this question on dev list?


was (Author: agura):
[~roman_s]

Roman, I've reviewed your pull request. Looks good for me. But I think that {{CacheConfiguration.getMaximumQueryIteratorCount()}}
and {{CacheConfiguration.setMaximumQueryIteratorCount()}} should be renamed to {{CacheConfiguration.getMaxQueryIteratorsCount()}}
and {{CacheConfiguration.setMaxQueryIteratorsCount()}} for the sake of uniformity with other
methods' names in {{CacheConfiguration}} class (using {{Max}} word and plural for {{Iterators}}).

> Add ability to configure maxIterCnt property in GridCacheQueryManager
> ---------------------------------------------------------------------
>
>                 Key: IGNITE-3421
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3421
>             Project: Ignite
>          Issue Type: Improvement
>          Components: cache
>    Affects Versions: 1.6
>            Reporter: Nikolay Tikhonov
>            Assignee: Roman Shtykh
>             Fix For: 1.8
>
>
> The number of open iterator limited by constant GridCacheQueryManager#MAX_ITERATORS.
Need to add ability to change the value. Also need to correct error message (see GridCacheQueryManager#executeQuery).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message