Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5A1B2200B85 for ; Wed, 10 Aug 2016 18:32:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 58D0D160AA4; Wed, 10 Aug 2016 16:32:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 952A2160AB1 for ; Wed, 10 Aug 2016 18:32:21 +0200 (CEST) Received: (qmail 57679 invoked by uid 500); 10 Aug 2016 16:32:20 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 57644 invoked by uid 99); 10 Aug 2016 16:32:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Aug 2016 16:32:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 978742C02A9 for ; Wed, 10 Aug 2016 16:32:20 +0000 (UTC) Date: Wed, 10 Aug 2016 16:32:20 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-3668) IGFS: Local secondary: Review all "throw new IOException" places. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 10 Aug 2016 16:32:22 -0000 [ https://issues.apache.org/jira/browse/IGNITE-3668?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D154= 15534#comment-15415534 ]=20 ASF GitHub Bot commented on IGNITE-3668: ---------------------------------------- GitHub user tledkov-gridgain opened a pull request: https://github.com/apache/ignite/pull/944 IGNITE-3668 IGFS: Local secondary: Review all "throw new IOException"= =E2=80=A6 =E2=80=A6 places. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-3668 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/944.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #944 =20 ---- commit 367f12de468fd362c1949c0f8ac36ec5cc7c2b74 Author: tledkov-gridgain Date: 2016-08-10T16:31:24Z IGNITE-3668 IGFS: Local secondary: Review all "throw new IOException" p= laces. ---- > IGFS: Local secondary: Review all "throw new IOException" places. > ----------------------------------------------------------------- > > Key: IGNITE-3668 > URL: https://issues.apache.org/jira/browse/IGNITE-3668 > Project: Ignite > Issue Type: Sub-task > Components: IGFS > Affects Versions: 1.7 > Reporter: Vladimir Ozerov > Assignee: Taras Ledkov > Fix For: 1.8 > > > We have several places in {{LocalIgfsSecondaryFileSystem}} where {{IOExce= ption}} is thrown. This is not correct, because: > 1) Exception must be specific. E.g. "path-not-found-exception". > 2) It doesn't make sense to throw {{IOException}} and cast it to {{IgfsEx= ception}} immediately. > Also we should not throw {{IgniteException}}. Proper {{IgfsException}} mu= st be thrown. > Let's review all these places and replace {{IOException}} with proper {{I= gfsException}} inheritor.=20 > Successful implementation should not introduce any new test failures. -- This message was sent by Atlassian JIRA (v6.3.4#6332)