Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5A87F200B5A for ; Thu, 4 Aug 2016 15:59:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 58F09160A6A; Thu, 4 Aug 2016 13:59:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9DE30160AB0 for ; Thu, 4 Aug 2016 15:59:21 +0200 (CEST) Received: (qmail 34958 invoked by uid 500); 4 Aug 2016 13:59:20 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 34787 invoked by uid 99); 4 Aug 2016 13:59:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Aug 2016 13:59:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A69A92C0D60 for ; Thu, 4 Aug 2016 13:59:20 +0000 (UTC) Date: Thu, 4 Aug 2016 13:59:20 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-3625) IGFS: Use common naming for IGFS meta and data caches. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 04 Aug 2016 13:59:22 -0000 [ https://issues.apache.org/jira/browse/IGNITE-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407807#comment-15407807 ] ASF GitHub Bot commented on IGNITE-3625: ---------------------------------------- GitHub user tledkov-gridgain opened a pull request: https://github.com/apache/ignite/pull/923 IGNITE-3625 IGFS: Use common naming for IGFS meta and data caches You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-3625 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/923.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #923 ---- commit 6be0a6f16fc76792dd35c82e992c7b685526c512 Author: tledkov-gridgain Date: 2016-08-04T09:31:44Z IGNITE-3625 IGFS: Use common naming for IGFS meta and data caches ---- > IGFS: Use common naming for IGFS meta and data caches. > ------------------------------------------------------ > > Key: IGNITE-3625 > URL: https://issues.apache.org/jira/browse/IGNITE-3625 > Project: Ignite > Issue Type: Task > Components: IGFS > Affects Versions: 1.6 > Reporter: Vladimir Ozerov > Assignee: Taras Ledkov > Fix For: 1.8 > > > Currently IGFS is configured by passing names of two caches: meta and data. See {{FileSystemConfiguration.metaCacheName}} and {{FileSystemConfiguration.dataCacheName}}. > These two caches are considered internal then and are not accessible for the user. > We need to do the following during node startup: > 1) If certain cache is configured as meta or data cache for multiple IGFS-es, or if it is configured as both meta and data cache for a single IGFS, then throw an exception. > Relevant code pieces: > {{IgfsProcessor.validateLocalIgfsConfigurations}} > {{IgfsProcessorSelfTest}}. > 2) During node startup change the name of this cache to {{igfs-IGFS_NAME-meta}} or {{igfs-IGFS_NAME-data}}. Change must be performed both inside IGFS config and cache config. > Relevant code pieces: > {{CacheConfiguration.name}} > {{FileSystemConfiguration.metaCacheName}} > {{FileSystemConfiguration.dataCacheName}} > {{IgfsUtils.prepareCacheConfiguration}} - where change will be done. > 3) If any of new names caches with any other cache name, an exception should be thrown. The most simple way: throw an exception if user-configured cache name starts with {{igfs-}} and ends with {{-meta}} or {{-data}}. > Relevant code pieces: > {{IgniteNamedInstance.initializeDefaultCacheConfiguration}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)