Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
Date: Tue, 16 Aug 2016 09:03:20 +0000 (UTC)
From: "Vladislav Pyatkov (JIRA)" <jira@apache.org>
To: issues@ignite.apache.org
Message-ID: <JIRA.12969926.1463384230000.315045.1471338200584@Atlassian.JIRA>
In-Reply-To: <JIRA.12969926.1463384230000@Atlassian.JIRA>
References: <JIRA.12969926.1463384230000@Atlassian.JIRA> <JIRA.12969926.1463384230655@arcas>
Subject: [jira] [Comment Edited] (IGNITE-3138) IgniteDataStreamer: failures
 are not shown on the streaming side
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Tue, 16 Aug 2016 09:03:22 -0000


    [ https://issues.apache.org/jira/browse/IGNITE-3138?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D154=
22381#comment-15422381 ]=20

Vladislav Pyatkov edited comment on IGNITE-3138 at 8/16/16 9:03 AM:
--------------------------------------------------------------------

My point of view:
1) This check was did for the check are buffers flushing needed. And this c=
an be skip at all (because buffer can by empty, if count of entry loaded pe=
r node divisible by {{bufSize}}, what unlikely).

2) Yes, =D0=B0 hang into a future it possible (this easy reproduce, if cust=
om Reciver hangs). Future get method (which return from {{addData}}) need t=
o invoke with timeout, even through timeout of Streamer is using.


was (Author: v.pyatkov):
My point of view:
1) This check was did for the check are buffers flushing needed. And this c=
an be skip at all (because buffer can by empty, if count of entry loaded pe=
r node divisible by {{bufSize}}, what unlikely).

2) Yes, =D0=B0 hang into a future it possible (this easy reproduce, if cust=
om Reciver hangs). Future get method (which return from {{addData}}) need t=
o invoke with timeout, even through timeout of Streamer is use.

> IgniteDataStreamer: failures are not shown on the streaming side
> ----------------------------------------------------------------
>
>                 Key: IGNITE-3138
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3138
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Denis Magda
>            Assignee: Vladislav Pyatkov
>         Attachments: DataStreamerFailuresTest.java
>
>
> If an exception happens during the streaming, the side that streams the d=
ata won't printed out anything in its logs even if IGNITE_QUIET set to fals=
e.
> This makes it's inconvenient to see whether there an issue happened durin=
g the streaming or not.
> Suggested improvements:
> - print out errors that happened during the streaming on the streaming si=
de;
> - Future that is returned from {{addData}} methods is not called in case =
of error. This must be fixed. So that the user is able to write a custom lo=
gic around this feature and process errors somehow.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)