ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-3668) IGFS: Local secondary: Review all "throw new IOException" places.
Date Wed, 10 Aug 2016 16:32:20 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415534#comment-15415534
] 

ASF GitHub Bot commented on IGNITE-3668:
----------------------------------------

GitHub user tledkov-gridgain opened a pull request:

    https://github.com/apache/ignite/pull/944

    IGNITE-3668 IGFS: Local secondary: Review all "throw new IOException"…

    … places.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-3668

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/944.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #944
    
----
commit 367f12de468fd362c1949c0f8ac36ec5cc7c2b74
Author: tledkov-gridgain <tledkov@gridgain.com>
Date:   2016-08-10T16:31:24Z

    IGNITE-3668 IGFS: Local secondary: Review all "throw new IOException" places.

----


> IGFS: Local secondary: Review all "throw new IOException" places.
> -----------------------------------------------------------------
>
>                 Key: IGNITE-3668
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3668
>             Project: Ignite
>          Issue Type: Sub-task
>          Components: IGFS
>    Affects Versions: 1.7
>            Reporter: Vladimir Ozerov
>            Assignee: Taras Ledkov
>             Fix For: 1.8
>
>
> We have several places in {{LocalIgfsSecondaryFileSystem}} where {{IOException}} is thrown.
This is not correct, because:
> 1) Exception must be specific. E.g. "path-not-found-exception".
> 2) It doesn't make sense to throw {{IOException}} and cast it to {{IgfsException}} immediately.
> Also we should not throw {{IgniteException}}. Proper {{IgfsException}} must be thrown.
> Let's review all these places and replace {{IOException}} with proper {{IgfsException}}
inheritor. 
> Successful implementation should not introduce any new test failures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message