ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Kuznetsov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-3172) Ignite-Cassandra serializers
Date Fri, 26 Aug 2016 06:17:20 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-3172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438526#comment-15438526
] 

Alexey Kuznetsov commented on IGNITE-3172:
------------------------------------------

Igor, I reviewed your PR.
In general looks good.

But I think we should have some tests for KryoSerializer.
It will be cool if we can just reuse tests from ignite-cassandra-store module, but passing
as a parameter KryoSerializer.

Also I have a question. Could you comment why did you change IgniteException to IllegalStateException
in KryoSerializer and JavaSerializer?
Also why not use U.closeQuiet() in KryoSerializer? Just add ignite-core to pom.xml (any way
ignite-core is a transitive dependency).


> Ignite-Cassandra serializers
> ----------------------------
>
>                 Key: IGNITE-3172
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3172
>             Project: Ignite
>          Issue Type: Improvement
>          Components: cache
>            Reporter: Igor Rudyak
>            Assignee: Igor Rudyak
>
> Ignite-Cassandra module should contain only "standard" serializer based on Java serialization
mechanism. 
> It should be a separate module in Ignite project for all other alternative implementations
of serializers (based on Kryo, providing compression, encryption and etc.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message