Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1CCC3200B4A for ; Tue, 5 Jul 2016 13:57:13 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1B386160A4F; Tue, 5 Jul 2016 11:57:13 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6725C160A60 for ; Tue, 5 Jul 2016 13:57:12 +0200 (CEST) Received: (qmail 35145 invoked by uid 500); 5 Jul 2016 11:57:11 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 35129 invoked by uid 99); 5 Jul 2016 11:57:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jul 2016 11:57:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 2E0D92C02A9 for ; Tue, 5 Jul 2016 11:57:11 +0000 (UTC) Date: Tue, 5 Jul 2016 11:57:11 +0000 (UTC) From: "Denis Magda (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (IGNITE-3426) Compute Engine: job ID is generated in a non unique way MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 05 Jul 2016 11:57:13 -0000 [ https://issues.apache.org/jira/browse/IGNITE-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362391#comment-15362391 ] Denis Magda edited comment on IGNITE-3426 at 7/5/16 11:56 AM: -------------------------------------------------------------- One liner fix. Job ID will be generated using this code {code} IgniteUuid jobId = IgniteUuid.fromUuid(ctx.localNodeId()); {code} Checking with TC. was (Author: dmagda): One liner fix. Job ID will be generated using this code {{ IgniteUuid jobId = IgniteUuid.fromUuid(ctx.localNodeId()); }} Checking with TC. > Compute Engine: job ID is generated in a non unique way > ------------------------------------------------------- > > Key: IGNITE-3426 > URL: https://issues.apache.org/jira/browse/IGNITE-3426 > Project: Ignite > Issue Type: Improvement > Reporter: Denis Magda > Assignee: Denis Magda > > Presently seems like new job IDs are generated in a way that is not guaranteed to be unique. > Specifically, job IDs are generated in: > {code} > IgniteUuid jobId = IgniteUuid.fromUuid(node.id()); > org/apache/ignite/internal/processors/task/GridTaskWorker.java:564) > {code} > fromUuid generates the new job ID using UUID passed to it + an AtomicInteger (who is always incremented). Since the UUID passed to it is the *destination node* and not the local node, in environments where the job submission is relatively even, the generated job ID might not be unique. > Think that the UUID used there is supposed to be the local node UUID. > Otherwise this can be a reason of the following exception > {noformat} > "Jobs map already contains mapping for key" > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)