ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrey Gura (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-3513) Cleanup worker is placed in the Thread's waiting queue using Thread.sleep method
Date Tue, 26 Jul 2016 05:31:20 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-3513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393257#comment-15393257
] 

Andrey Gura commented on IGNITE-3513:
-------------------------------------

>From my point of view this benchmark is too synthetic. It would be better measure throughput
of real cache operations with different solutions. Make sure that JVM has enough memory during
measurements.

> Cleanup worker is placed in the Thread's waiting queue using Thread.sleep method
> --------------------------------------------------------------------------------
>
>                 Key: IGNITE-3513
>                 URL: https://issues.apache.org/jira/browse/IGNITE-3513
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 1.6
>            Reporter: Denis Magda
>            Assignee: Eduard Shangareev
>             Fix For: 1.7
>
>
> There is a bug in current implementation of {{GridCacheTtlManager#CleanupWorker}}.
> Refer to the implementation's code snippet and the details below.
> {code}
> EntryWrapper first = pendingEntries.firstx();
>  if (first != null) {
>    long waitTime = first.expireTime - U.currentTimeMillis();
>    if (waitTime > 0)
>       U.sleep(waitTime);
>  }
> {code}
> 1. Put first item with TTL = 1 hour. CleanupWorker will go to sleep for 1 hour.
> 2. Put second item with TTL = 1 minute. Since 
> CleanupWorker's thread sleeps now, second item will not be expired at the time.
> NOTE: This scenario is easily to reproducible if first and second items are put into
cache asynchronously. If try to put them in same thread one-by-one expiration may work fine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message