Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AD709200AF6 for ; Fri, 27 May 2016 18:51:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AA930160A10; Fri, 27 May 2016 16:51:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2D571160A12 for ; Fri, 27 May 2016 18:51:14 +0200 (CEST) Received: (qmail 65113 invoked by uid 500); 27 May 2016 16:51:13 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 65102 invoked by uid 99); 27 May 2016 16:51:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 May 2016 16:51:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 310352C1F6E for ; Fri, 27 May 2016 16:51:13 +0000 (UTC) Date: Fri, 27 May 2016 16:51:13 +0000 (UTC) From: "Semen Boikov (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-2969) Optimistic transactions support in deadlock detection MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 27 May 2016 16:51:14 -0000 [ https://issues.apache.org/jira/browse/IGNITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304325#comment-15304325 ] Semen Boikov commented on IGNITE-2969: -------------------------------------- Did quick review, have some comments: - you added additional 'sychronized' usages, need check that it does not impact performance, please execute some single-node benchmark. If performance is impacted then need to use additional synchronization only if timeout is enabled - in some places there is nested synchronization, I think it can be changed to use only one mutex - now transactions implement GridTimeoutObject and 'isTimedOut' is called in some random places, I think this complicates timeout handling logic and is not really needed. Let's remove GridTimeoutObject from tx, and all timeout handling logic should remain only in transaction futures (lock and prepare futures) > Optimistic transactions support in deadlock detection > ----------------------------------------------------- > > Key: IGNITE-2969 > URL: https://issues.apache.org/jira/browse/IGNITE-2969 > Project: Ignite > Issue Type: Improvement > Components: cache > Reporter: Andrey Gura > Assignee: Andrey Gura > Fix For: 1.7 > > > Deadlock detection doesn't support optimistic transactions now. It should be implemented. -- This message was sent by Atlassian JIRA (v6.3.4#6332)