ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-2865) Continuous query event passed to filter should be immutable for users.
Date Mon, 23 May 2016 10:20:12 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-2865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296196#comment-15296196
] 

ASF GitHub Bot commented on IGNITE-2865:
----------------------------------------

GitHub user tledkov-gridgain opened a pull request:

    https://github.com/apache/ignite/pull/744

    IGNITE-2865 Continuous query event passed to filter should be immutale for users.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gridgain/apache-ignite ignite-2865

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/744.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #744
    
----
commit b9feb2900ee2660685710b17503b774765e7bdae
Author: tledkov-gridgain <tledkov@gridgain.com>
Date:   2016-05-20T14:10:13Z

    IGNITE-2865 Continuous query event passed to filter should be immutable for users.

----


> Continuous query event passed to filter should be immutable for users.
> ----------------------------------------------------------------------
>
>                 Key: IGNITE-2865
>                 URL: https://issues.apache.org/jira/browse/IGNITE-2865
>             Project: Ignite
>          Issue Type: Task
>          Components: cache
>    Affects Versions: 1.5.0.final
>            Reporter: Vladimir Ozerov
>            Assignee: Taras Ledkov
>            Priority: Critical
>              Labels: community, important
>             Fix For: 1.7
>
>
> *Problem*
> When event is passed to continuous query filter, it can be used only in scope of this
method. The reason is that if filter returns {{false}}, the method {{CacheContinuousQueryEntry.markFiltered()}}
is called. This method *clears* key and values.
> *Solution*
> We should not clear key and values. Instead, we should properly check for {{FILTERED_ENTRY}}
flag in all methods where {{key/newVal/oldVal/depInfo}} are used. This includes generated
{{readFrom()/writeTo()}} methods as well - their manual change will be required.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message