ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Denis Magda (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-967) Internal thread locals are not always cleaned
Date Thu, 07 Apr 2016 21:48:25 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231149#comment-15231149
] 

Denis Magda commented on IGNITE-967:
------------------------------------

Alexei, thanks for the investigation. I think that we can close the ticket then.

> Internal thread locals are not always cleaned
> ---------------------------------------------
>
>                 Key: IGNITE-967
>                 URL: https://issues.apache.org/jira/browse/IGNITE-967
>             Project: Ignite
>          Issue Type: Bug
>          Components: general
>    Affects Versions: sprint-4
>            Reporter: Valentin Kulichenko
>            Assignee: Alexei Scherbakov
>            Priority: Critical
>              Labels: important
>             Fix For: 1.6
>
>
> One of our users reported that he sees warnings in Tomcat's log when the application
that's running Ignite in embedded mode is undeployed:
> {code}
> SEVERE: The web application [/XXX] created a ThreadLocal with key of type [org.apache.ignite.internal.util.GridSpinReadWriteLock$1]
(value [org.apache.ignite.internal.util.GridSpinReadWriteLock$1@2c2858af]) and a value of
type [java.lang.Integer] (value [0]) but failed to remove it when the web application was
stopped. Threads are going to be renewed over time to try and avoid a probable memory leak.
> {code}
> There is also the similar warning for {{GridToStringBuilder.threadCache}}. 
> While it's usually OK not to clean thread locals on standalone node, in app server it
can cause a memory leak.
> To avoid such issues I suggest to add a special step after all test suites that will
check thread locals in test runner thread. If we have this check in CI, we will fix it once
and for always.
> Thread local values can be introspected through {{Thread.threadLocals}} variable. It
would also be a good idea to check Tomcat's sources on how it's done there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message