ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Igor Sapego (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (IGNITE-2920) CPP: IgniteError should be derived from std::runtime_error not from std::exception
Date Thu, 31 Mar 2016 11:59:25 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219779#comment-15219779
] 

Igor Sapego edited comment on IGNITE-2920 at 3/31/16 11:59 AM:
---------------------------------------------------------------

Vladimir,
The problem is that the signature of the {{std::exception::what()}} method has changed in
C\+\+11. Thus we Ignite will not be able to be compiled for modern C\+\+ if we leave it as
it is now.
As an alternative we can adjust signature of the {{IgniteError::what()}} with macros so it
will be valid for both C\+\+11 and C\+\+03.
What do you think?


was (Author: isapego):
Vladimir,
The problem is that the signature of the {{std::exception::what()}} method has changed in
C\+\+11. Thus we Ignite will not be able to be compiled for modern C\+\+ if we leave it as
it is now.
As an alternative we can adjust signature of the {{IgniteError::what()}} with macros so it
will be valid for both C\+\+11 and C++03.
What do you think?

> CPP: IgniteError should be derived from std::runtime_error not from std::exception
> ----------------------------------------------------------------------------------
>
>                 Key: IGNITE-2920
>                 URL: https://issues.apache.org/jira/browse/IGNITE-2920
>             Project: Ignite
>          Issue Type: Task
>          Components: platforms
>    Affects Versions: 1.5.0.final
>            Reporter: Igor Sapego
>            Assignee: Igor Sapego
>             Fix For: 1.6
>
>
> It seems like std::exception is not supposed to be used as a base class by user classes.
It is suggested to use std::runtime_error instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message