Return-Path: X-Original-To: apmail-ignite-issues-archive@minotaur.apache.org Delivered-To: apmail-ignite-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5F8F71848F for ; Tue, 16 Feb 2016 17:33:19 +0000 (UTC) Received: (qmail 54547 invoked by uid 500); 16 Feb 2016 17:33:18 -0000 Delivered-To: apmail-ignite-issues-archive@ignite.apache.org Received: (qmail 54442 invoked by uid 500); 16 Feb 2016 17:33:18 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 54218 invoked by uid 99); 16 Feb 2016 17:33:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Feb 2016 17:33:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 23E972C1F64 for ; Tue, 16 Feb 2016 17:33:18 +0000 (UTC) Date: Tue, 16 Feb 2016 17:33:18 +0000 (UTC) From: "Nikolay Tikhonov (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (IGNITE-2604) CacheContinuousQueryBatchAck is sent to nodes that doesn't hold cache data MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-2604?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D151= 48955#comment-15148955 ]=20 Nikolay Tikhonov commented on IGNITE-2604: ------------------------------------------ Removed duplicate code from tests. Replaced incorrect methods calls. > CacheContinuousQueryBatchAck is sent to nodes that doesn't hold cache dat= a > -------------------------------------------------------------------------= - > > Key: IGNITE-2604 > URL: https://issues.apache.org/jira/browse/IGNITE-2604 > Project: Ignite > Issue Type: Bug > Components: cache > Affects Versions: 1.5.0.final > Reporter: Denis Magda > Assignee: Nikolay Tikhonov > Priority: Blocker > Fix For: 1.6 > > > Presently {{CacheContinuousQueryBatchAck}} is sent to every node of the c= luster including client nodes but in fact it has to be sent to backup nodes= only. The reason is that the list of the backups is retrieved with {{ctx.d= iscovery().cacheNodes(topVer)}} method which returns all the nodes where at= least one cache is registered. > Refer to {{CacheContinuousQueryHandler.sendBackupAcknowledge}} method bod= y > {noformat} > for (AffinityTopologyVersion topVer : t.get2()) > nodes.addAll(ctx.discovery().cacheNodes(topVer)); > {noformat} > The list has to be formed by remote nodes that contain only a particular = cache > {noformat} > for (AffinityTopologyVersion topVer : t.get2()) > nodes.addAll(ctx.discovery().remoteCacheNodes(cctx.name(), topVer)); > {noformat} > and finally the ack has to be sent only if a node is not a client node > {noformat} > for (ClusterNode node : nodes) { > if (!node.isClient()) { > try { > cctx.io().send(node, msg, GridIoPolicy.SY= STEM_POOL); > {noformat} > Next, in my understanding there is no need to register CacheContinuousQue= ryBatchAck handler on the client side. Presently it's registered in {{Cache= ContinuousQueryManager.start0}} method. > Finally, since currently the ack is sent to clients as well the following= warning floods logs in some unclear cases > {noformat} > 20160208 12:56:30.301 WARN [sys-#7%null%] org.apache.ignite.internal.proc= essors.cache.GridCacheIoManager [] - Received message without registered ha= ndler (will ignore) [msg=3DCacheContinuousQueryBatchAck [routineId=3Ddf328a= 9f-6a63-40f7-8a1b-923cfadb6337, updateCntrs=3D{193=3D1455, 898=3D1434, 581= =3D307, 584=3D159, 75=3D376, 331=3D233, 652=3D434, 13=3D420, 910=3D923, 143= =3D249, 147=3D619, 150=3D1185, 598=3D338, 728=3D1168, 90=3D598, 346=3D1169,= 283=3D214, 934=3D388, 615=3D310, 807=3D140, 1002=3D1132, 555=3D344, 365=3D= 215, 941=3D342, 946=3D515, 1015=3D635, 56=3D614, 378=3D1130, 827=3D720, 956= =3D5675}], nodeId=3Dd78ac9e5-60dd-4fa9-a8eb-7c5c36e189af, locTopVer=3DAffin= ityTopologyVersion [topVer=3D248, minorTopVer=3D1], msgTopVer=3DAffinityTop= ologyVersion [topVer=3D-1, minorTopVer=3D0], cacheDesc=3DDynamicCacheDescri= ptor [deploymentId=3Db8776e0c251-eb7db0e0-c35f-4a05-af44-5295c4cfdc01, locC= fg=3Dfalse, staticCfg=3Dtrue, started=3Dtrue, cacheType=3DUSER, template=3D= false, pluginMgr=3DGridCacheManagerAdapter [starting=3Dfalse], updatesAllow= ed=3Dtrue, startTopVer=3Dnull, rcvdOnDiscovery=3Dtrue, cacheName=3DGETS_ORD= ER_MAP]] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)