Return-Path: X-Original-To: apmail-ignite-issues-archive@minotaur.apache.org Delivered-To: apmail-ignite-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 622C0182FE for ; Mon, 1 Feb 2016 07:44:02 +0000 (UTC) Received: (qmail 6704 invoked by uid 500); 1 Feb 2016 07:43:40 -0000 Delivered-To: apmail-ignite-issues-archive@ignite.apache.org Received: (qmail 6666 invoked by uid 500); 1 Feb 2016 07:43:39 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 6648 invoked by uid 99); 1 Feb 2016 07:43:39 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Feb 2016 07:43:39 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id CD25F2C044E for ; Mon, 1 Feb 2016 07:43:39 +0000 (UTC) Date: Mon, 1 Feb 2016 07:43:39 +0000 (UTC) From: "Vladimir Ozerov (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Closed] (IGNITE-2408) Hot spot in GridDhtAtomicCache$DeferredResponseBuffer.addResponse() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-2408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Ozerov closed IGNITE-2408. ----------------------------------- > Hot spot in GridDhtAtomicCache$DeferredResponseBuffer.addResponse() > ------------------------------------------------------------------- > > Key: IGNITE-2408 > URL: https://issues.apache.org/jira/browse/IGNITE-2408 > Project: Ignite > Issue Type: Sub-task > Components: cache > Affects Versions: 1.5.0.final > Reporter: Vladimir Ozerov > Assignee: Ilya Lantukh > Priority: Critical > Fix For: 1.6 > > > Problems: > 1) DeferredResponseBuffer.respVers is ConcurrentLinkedDeque8 and size() method is called on it. It is O(N) for this collection, hence the hot spot. > 2) We use read-write lock for very small updates. This is not efficient. > Probably we should simply switch to (sycnhronized + ArrayList) and this will be enough. > If synchronized is not an option, at the very least we must use collection with O(1) size or maintain separate counter (e.g. LongAccumulator). -- This message was sent by Atlassian JIRA (v6.3.4#6332)