ignite-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anton Vinogradov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (IGNITE-2555) Include offheap usage in metrics report
Date Wed, 10 Feb 2016 16:03:18 GMT

    [ https://issues.apache.org/jira/browse/IGNITE-2555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141055#comment-15141055
] 

Anton Vinogradov commented on IGNITE-2555:
------------------------------------------

Konstantin,

Pullrequest looks good to me.
But, as I told before, each commit should be covered by tests.

As far as I can see metrics works when log.isInfoEnabled() is true and IgniteConfiguration.getMetricsLogFrequency()
is not null.
I see no tests where metricsLogFrequency set to non default value.

So, before merging changes to master new test should be created with metricsLogFrequency set
to 1 second, and log.isInfoEnabled is true.
This test should start couple of nodes and check somehow that nodes alive 20 seconds later.
For example you may check that cache put/get works.

Also, good point is to add one more test that checks output is correct. 
You can set custom IgniteLogger to IgniteConfiguration and check input of info() method.


> Include offheap usage in metrics report
> ---------------------------------------
>
>                 Key: IGNITE-2555
>                 URL: https://issues.apache.org/jira/browse/IGNITE-2555
>             Project: Ignite
>          Issue Type: Task
>    Affects Versions: 1.5.0.final
>            Reporter: Sergey Kozlov
>            Assignee: Konstantin Margorin
>            Priority: Minor
>              Labels: newbie
>
> The local node prints out the set of key parameters in its log (or console). It makes
sense to add offheap usage (used/free/committed) to that report.
> {noformat}
> Metrics for local node (to disable set 'metricsLogFrequency' to 0)
>     ^-- Node [id=41b12e0f, name=null]
>     ^-- H/N/C [hosts=1, nodes=14, CPUs=8]
>     ^-- CPU [cur=16,73%, avg=17,39%, GC=0,6%]
>     ^-- Heap [used=1364MB, free=27,44%, comm=1881MB]
>     ^-- Public thread pool [active=0, idle=16, qSize=0]
>     ^-- System thread pool [active=1, idle=15, qSize=0]
>     ^-- Outbound messages queue [size=0]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message