Return-Path: X-Original-To: apmail-ignite-issues-archive@minotaur.apache.org Delivered-To: apmail-ignite-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8544E18644 for ; Wed, 13 Jan 2016 16:22:45 +0000 (UTC) Received: (qmail 94701 invoked by uid 500); 13 Jan 2016 16:22:40 -0000 Delivered-To: apmail-ignite-issues-archive@ignite.apache.org Received: (qmail 94658 invoked by uid 500); 13 Jan 2016 16:22:40 -0000 Mailing-List: contact issues-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list issues@ignite.apache.org Received: (qmail 94640 invoked by uid 99); 13 Jan 2016 16:22:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jan 2016 16:22:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E2EB32C1F6B for ; Wed, 13 Jan 2016 16:22:39 +0000 (UTC) Date: Wed, 13 Jan 2016 16:22:39 +0000 (UTC) From: "Pavel Tupitsyn (JIRA)" To: issues@ignite.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (IGNITE-2324) .NET: Code analysis MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/IGNITE-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15094094#comment-15094094 ] Pavel Tupitsyn edited comment on IGNITE-2324 at 1/13/16 4:22 PM: ----------------------------------------------------------------- Findings: * SonarQube is too complicated to set up on TC, skip it for now * .FxCop file is an old and inconvenient way of setting up analysis, not compatible with VS2012+ built-in analyzer. We should configure rule set in .ruleset file. * ReSharper inspections are built-in on TC TODO: * Set up .ruleset file with relevant rules * Enable analysis on build so that VS shows warnings during development * Run separate step on TC with /p:CodeAnalysisTreatWarningsAsErrors that will fail in case of analysis issues * Add ReSharper inspections step was (Author: ptupitsyn): Findings: * SonarQube is too complicated to set up on TC, skip it for now * .FxCop file is an old and inconvenient way of setting up analysis, not compatible with VS2010+ built-in analyzer. Instead, we should configure rule set in .ruleset file. * ReSharper inspections are built-in on TC TODO: * Get rid of fxcop file * Set up .ruleset file with relevant rules * Enable analysis on build so that VS shows warnings during development * Run separate step on TC with /p:CodeAnalysisTreatWarningsAsErrors that will fail in case of analysis issues * Add ReSharper inspections step > .NET: Code analysis > ------------------- > > Key: IGNITE-2324 > URL: https://issues.apache.org/jira/browse/IGNITE-2324 > Project: Ignite > Issue Type: Task > Components: interop > Affects Versions: 1.1.4 > Reporter: Pavel Tupitsyn > Assignee: Pavel Tupitsyn > Fix For: 1.6 > > > * Investigate code analysis tools (FxCop, SonarQube, etc) > * Set up a step on TeamCity > * Set up visual studio to check on build > * Modify code (adjust inspections/suppressions) -- This message was sent by Atlassian JIRA (v6.3.4#6332)